-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java client codegen cleanup #20691
Merged
wing328
merged 20 commits into
OpenAPITools:master
from
ronreynolds:java-client-codegen-cleanup
Feb 20, 2025
Merged
Java client codegen cleanup #20691
wing328
merged 20 commits into
OpenAPITools:master
from
ronreynolds:java-client-codegen-cleanup
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the new value is immediately visible to all other threads
…of creating new ApiClient every time
…code cleanup; no functional changes
…ls, possibly due to timezone (Locale.ROOT) of local system
…-enabled unit-test
…f duplicate FOO.equals(getLibrary()) checks; also using isLibrary() wherever possible
…ack serialization-lib setting code due to unit-test failure (still a mystery)
…ged (as shown by unit-test)
lgtm. thanks for enhancement 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Client: Java
Enhancement: Code Cleanup
General refactoring, removal of deprecated things, commenting, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some code cleanup of
JavaClientCodegen
and a few minor behavior changesString.equals
withboolean
variables orisLibrary()
in cases where the same library test isn't performed multiple timesboolean
assertEquals
args inJavaClientCodegenTest
are backwards (expected vs actual)assertEquals
methods with expected and actual args swapped but identical behaviorassertEquals
to testng to make IntelliJ happy but there's so much more to do here in a future PRPR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)