Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java client codegen cleanup #20691

Merged
merged 20 commits into from
Feb 20, 2025

Conversation

ronreynolds
Copy link
Contributor

some code cleanup of JavaClientCodegenand a few minor behavior changes

  • replacing many String.equals with boolean variables or isLibrary() in cases where the same library test isn't performed multiple times
  • removed pointless boxing/unboxing of boolean
  • some line-wrapping (much of it removed because there were too many changes in diff; perhaps a later MR...)
  • removed possibly-moot edge-case where "okhttp-gson" and "" would have been treated slightly differently
  • many assertEquals args in JavaClientCodegenTest are backwards (expected vs actual)
    • also this unit-test uses 3 different assertion frameworks (junit-jupiter, testng, and assertj)
    • junit-jupiter and testng both have assertEquals methods with expected and actual args swapped but identical behavior
    • converted a few junit-jupiter assertEquals to testng to make IntelliJ happy but there's so much more to do here in a future PR

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

ronreynolds and others added 20 commits February 9, 2025 10:11
…the new value is immediately visible to all other threads
…ls, possibly due to timezone (Locale.ROOT) of local system
…f duplicate FOO.equals(getLibrary()) checks; also using isLibrary() wherever possible
…ack serialization-lib setting code due to unit-test failure (still a mystery)
@wing328
Copy link
Member

wing328 commented Feb 20, 2025

lgtm. thanks for enhancement 👍

@wing328 wing328 merged commit 1311107 into OpenAPITools:master Feb 20, 2025
15 checks passed
@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Feb 20, 2025
@wing328 wing328 added this to the 7.12.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants