Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-flight] fix: always set http status in streaming response #18604

Merged
merged 1 commit into from
May 8, 2024

Conversation

daniel-sc
Copy link
Contributor

…and use http status from spec

This additionally adds streaming stubs for all methods (rather err on the side of too much stubs).

@jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…e http status from spec

 This additionally adds streaming stubs for all methods (rather err on the side of too much stubs).
@wing328 wing328 merged commit 9db0e32 into OpenAPITools:master May 8, 2024
16 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 8, 2024
@daniel-sc daniel-sc deleted the php-flight-improvements branch May 8, 2024 17:39
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
…e http status from spec (OpenAPITools#18604)

This additionally adds streaming stubs for all methods (rather err on the side of too much stubs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants