-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart] [dart-dio] Support Dart3 #18001
Conversation
Might also update the readme. right now it states it only generates a 2x client, but I assume this PR makes it generate 3 (at least I am hoping so). https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/dart.md |
Removed version numbers as it is now compatible with both 2.x and 3.x. Also bumped SDK to
|
Thanks! Did you attempt to update they keywords file based one Dart 3.3.0 and there are just no changes? |
Thanks, I was not aware of that file. Updated the keywords in the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
@wing328 Can you please approve the workflows
Would be great to get this completed! |
shall we also update the workflow to test with dart3: https://github.com/OpenAPITools/openapi-generator/actions/runs/8552245804/workflow?pr=18001#L35 so that both dart2 and 3 are tested in the CI workflows? |
Any way we can get this finished? I would really like to use this! |
@marc-wilson have you tested this change locally? does it work for you using Dart3? we don't have dart 3 test in the workflow at the moment |
I have not. I'm not familiar with what it takes to clone the repo and go through the testing process. If there is a concern around stability and you are requesting help for testing, I can take a look. But, mainly just a champion for dart 3 support as i'm currently writing out api clients manually for dart. |
@marc-wilson are you familiar with github workflow? can you help file a PR on top of this one to update https://github.com/OpenAPITools/openapi-generator/actions/runs/8552245804/workflow?pr=18001#L35 to test both dart 2 and 3? |
I've just merged it. Please give it a try with dart2 and 3 with the latest snapshot build when you've time. snapshot build can be found in the project's readme. |
Docs should get regenerated |
I don't know if this the right place for my question but this PR was the latest work on the dart generator I found. It seems that the dart generator is using a fairly outdated version of the http library ( |
do you mind filing a PR to update http library to newer version? |
Support Dart3 SDK.
cc tech:
@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)