Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][resteasy] fixes serialize list of files and deserialize file #17813

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicolasiannarilli
Copy link

@nicolasiannarilli nicolasiannarilli commented Feb 7, 2024

fix serialize multipart with list of files : serialize a list with toString

fix deserialize byte and file : test on GenericType always return false

fix downloadFileFromResponse : prepareDownloadFile(response) return a temp file and copy failed with FileAlreadyExistException

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fix serialize multipart with files
fix deserialize byte and file
@nicolasiannarilli nicolasiannarilli changed the title fix resteasy ApiClient.mustache java resteasy fixes serialize list of files and deserialize file Feb 7, 2024
@nicolasiannarilli nicolasiannarilli changed the title java resteasy fixes serialize list of files and deserialize file [java][resteasy] fixes serialize list of files and deserialize file Feb 7, 2024
@wing328
Copy link
Member

wing328 commented Feb 15, 2024

@nicolasiannarilli thanks for the PR. Is this ready for review and merge?

@wing328 wing328 added this to the 7.4.0 milestone Feb 15, 2024
@wing328 wing328 modified the milestones: 7.4.0, 7.5.0 Mar 11, 2024
@wing328 wing328 modified the milestones: 7.5.0, 7.6.0 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants