Fix spring generator dto annotations for xml support

[tomyy]

Fixes #16915 by changing the spring-pojo template to correctly place the JacksonXmlProperty annotations.

• Modify the test added for [BUG] [Java] uppercase property leads to duplicate fields after serialization #5705 so that it checks the corrected template.
• add test to the openapi3/server/petstore/springboot-3 sample

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg

[slogic]

Will this fix be backported to 6.x.x branch ?

[martin-mfg]

Will this fix be backported to 6.x.x branch ?

Most probably not.
see https://mvnrepository.com/artifact/org.openapitools/openapi-generator - There is no backporting in the OpenAPI Generator project.

[tomyy]

@wing328 when will this fix be merged? We are stuck on version 6.4 until this is merged.

[wing328]

@tomyy I wonder if you can take a look at the following errors when you've time:

        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

[INFO] Running org.openapitools.OpenApiGeneratorApplicationTests
2024-05-11T23:22:25.712+08:00  INFO 21736 --- [           main] t.c.s.AnnotationConfigContextLoaderUtils : Could not detect default configuration classes for test class [org.openapitools.OpenApiGeneratorApplicationTests]: OpenApiGeneratorApplicationTests does not declare any static, non-private, non-final, nested classes annotated with @Configuration.
2024-05-11T23:22:25.716+08:00  INFO 21736 --- [           main] .b.t.c.SpringBootTestContextBootstrapper : Found @SpringBootConfiguration org.openapitools.OpenApiGeneratorApplication for test class org.openapitools.OpenApiGeneratorApplicationTests
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 s - in org.openapitools.OpenApiGeneratorApplicationTests
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   JacksonTest.shouldSerializeToXml:27 ▒ InvalidDefinition Cannot construct instance of `org.openapitools.model.Category` (no Creators, like default constructor, exist): neither default (no-arguments) nor with-arguments Creator found
 at [Source: (StringReader); line: 1, column: 11] (through reference chain: org.openapitools.model.Pet["Category"])
[INFO]
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------

Command: mvn integration-test -f samples/openapi3/server/petstore/springboot-3/pom.xml

[tomyy]

@wing328 the problem seems to be caused by the new "allArgsConstructor" option (#18538).

I can confirm that by checking out commit 2a1b4f9 and running mvn integration-test -f samples/openapi3/server/petstore/springboot-3/pom.xml on that commit which on my machine also fails with the same error message.

If that new "allArgsConstructor" option is active and a model class like Category doesn't have any required parameters the templates do no longer generate a no-arg constructor (which is required by Jackson Databind). The test runs successfully if I manually add a no-arg constructor to that class.

For model classes like Pet there are three constructors generated:

• no-args
• only the required parameters
• all parameters

The fix will need changes to the JavaSpring/pojo.mustache template, however I'm currently unsure on how to best implement it (the required conditions seem very convoluted in an already complex template)

Note that other Java related templates could potentially be impacted too. When fixing this I will add more test cases for more Java petstore clients and servers.

[wing328]

@tomyy thanks for the details. Didn't realize it's broken due to the allArgsConstructor.

@jpfinne can you please review the issue when you've time? I think likely you need to update the tests.

[jpfinne]

@wing328 the no arg constructor should be fixed in #18650