Skip to content

Conversation

@madorb
Copy link
Contributor

@madorb madorb commented Oct 16, 2023

This will remove unused imports on apache commons-logging from the java webclient generator, which allows consumers a bit more freedom over logging libraries in their applications (e.g. in our organization we generally only allow libraries to expose slf4j).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg
@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog

@martin-mfg
Copy link
Contributor

martin-mfg commented Oct 16, 2023

Hi, thanks for the PR! It generally looks good to me.

I just want to point out that your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let us know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Oct 17, 2023

Looks like Ben is using his work github account to commit the change, which is perfectly the fine.

@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Oct 17, 2023
@wing328 wing328 added this to the 7.1.0 milestone Oct 17, 2023
@wing328 wing328 merged commit d642141 into OpenAPITools:master Oct 17, 2023
@madorb
Copy link
Contributor Author

madorb commented Oct 17, 2023

Looks like Ben is using his work github account to commit the change, which is perfectly the fine.

yep that was the case :) thanks so much all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants