Skip to content

Conversation

@joshraker
Copy link
Contributor

@joshraker joshraker commented Oct 13, 2023

Fixes #16811

I don't see tests for the generated client in the repo so I threw together these tests just to sanity-check. They passed ✅.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@joshraker
Copy link
Contributor Author

Go Technical Committee: @antihax, @grokify, @kemokemo, @jirikuncar, @ph4r5h4d, @lwj5

@wing328
Copy link
Member

wing328 commented Oct 13, 2023

thanks for the PR. what about creating a new file named api_cliet_test.go in https://github.com/OpenAPITools/openapi-generator/tree/master/samples/openapi3/client/petstore/go and add some tests for xmlCheck, jsonCheck?

@wing328 wing328 added this to the 7.1.0 milestone Oct 13, 2023
@joshraker
Copy link
Contributor Author

joshraker commented Oct 13, 2023

Thanks for pointing me in the right direction. The members had to be exported in order to test them outside of the package but that shouldn't be a problem. Does https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/go need the tests as well?

@wing328
Copy link
Member

wing328 commented Oct 13, 2023

Does https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/go need the tests as well?

No. Eventually we will consolidate the Go petstore tests to use only OpenAPI v3 spec.

Have a nice weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][GO] Generated client does not treat all media types with the suffix +json as JSON or +xml as XML

2 participants