[JavaSpring] Generate bean validation annotations for form parameters #16514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a
POST
endpoint which consumesapplication/x-www-form-urlencoded
with the JavaSpring module, the resulting method in theApi
class is missing bean validation annotations such as@NotNull
,@Min
and@Max
. Changing the endpoint to aGET
with the same parameters as query parameters leads to a Java method with an identical signature, but then the validation annotations are present.This PR copies the relevant part of
queryParams.mustache
toformParams.mustache
. The containedbeanValidationFormParams.mustache
is slightly simpler than thebeanValidationQueryParams.mustache
, becauseformParams.mustache
does not consider theuseOptional
flag (I didn't want to add support for that in this PR, as I don't know what the implications are).PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(7.0.1 - patch release),7.1.x
(minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)
Please verify whether this is considered a breaking change according to your definition.