Skip to content

Could org.openapitools:cxf-annotated-basepath:war:1.0.0 drop off redundant dependencies? #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slimming-fat
Copy link

image
image
image
image
image
image

Hi, I found that org.openapitools:cxf-annotated-basepath:war:1.0.0’s pom file introduced 68 dependencies. However, among them, 20 libraries (29% have not been used by your project), the redundant dependencies are listed below.

More seriously,19 redundant libraries have not been maintained by developers for more than 3 years(outdated dependencies).

Reduce these unused dependencies can help prevent introducing bugs/vulnerabilities from dependencies with outdated. Meanwhile, it can minimize the project size. To safely remove redundant dependencies, I constructed a complete call graph (resolved most of Java reflection and dynamic binding), and validated that they have not been used by the client code.

This PR org.openapitools:cxf-annotated-basepath:war:1.0.0 for removing the redundant dependencies have passed the tests.

Best regards

Redundant dependencies

Redundant direct dependencies:

      joda-time:joda-time:2.10.13:compile [629 KB]

Redundant indirect dependencies:

     com.sun.xml.dtd-parser:dtd-parser:1.4.1:compile [61 KB]
     org.jvnet.staxex:stax-ex:1.8.1:compile [37 KB]
     org.apache.ant:ant-launcher:1.10.5:compile [18 KB]
     javax.annotation:javax.annotation-api:1.3:compile [25 KB]
     com.sun.istack:istack-commons-runtime:3.0.8:compile [26 KB]
     org.checkerframework:checker-compat-qual:2.5.2:compile [5 KB]
     com.google.code.findbugs:jsr305:3.0.2:compile [19 KB]
     jakarta.xml.bind:jakarta.xml.bind-api:2.3.2:compile [112 KB]
     com.sun.xml.fastinfoset:FastInfoset:1.2.16:compile [309 KB]
     javax.ws.rs:jsr311-api:1.1.1:compile [45 KB]
     org.apache.ant:ant:1.10.5:compile [2 MB]
     org.glassfish.jaxb:txw2:2.3.2:compile [70 KB]
     com.sun.xml.bind.external:rngom:2.3.2:compile [308 KB]
     com.google.errorprone:error_prone_annotations:2.2.0:compile [13 KB]
     com.google.j2objc:j2objc-annotations:1.1:compile [8 KB]
     org.ow2.asm:asm:7.0:compile [111 KB]
     jakarta.activation:jakarta.activation-api:1.2.1:compile [43 KB]
     org.glassfish.jaxb:xsom:2.3.2:compile [405 KB]
     com.sun.xml.bind.external:relaxng-datatype:2.3.2:compile [19 KB] 

Outdated dependencies

javax.annotation:javax.annotation-api:1.3 (2389 days without maintenance)
com.sun.xml.dtd-parser:dtd-parser:1.4.1 (1563 days without maintenance)
jakarta.activation:jakarta.activation-api:1.2.2(1600 days without maintenance)
com.sun.xml.fastinfoset:FastInfoset:1.2.16 (1564 days without maintenance)
org.ow2.asm:asm:7.0 (1625 days without maintenance)
org.glassfish.jaxb:txw2:2.3.2 (1558 days without maintenance)
com.google.errorprone:error_prone_annotations:2.2.0 (1916 days without maintenance)
javax.ws.rs:jsr311-api:1.1.1 (4884 days without maintenance)
org.jvnet.staxex:stax-ex:1.8.1 (1564 days without maintenance)
org.apache.ant:ant-launcher:1.10.5 (1734 days without maintenance)
com.google.j2objc:j2objc-annotations:1.1 (2271 days without maintenance)
org.checkerframework:checker-compat-qual:2.5.2 (1772 days without maintenance)
jakarta.xml.bind:jakarta.xml.bind-api:2.3.2 (1564 days without maintenance)
com.google.code.findbugs:jsr305:3.0.2 (2200 days without maintenance)
org.apache.ant: ant:1.10.5 (1734 days without maintenance)
com.sun.xml.bind.external:relaxng-datatype:2.3.2 (1564 days without maintenance)
com.sun.xml.bind.external:rngom:2.3.2 (1564 days without maintenance)
org.glassfish.jaxb:xsom:2.3.2 (1564 days without maintenance)
com.sun.istack:istack-commons-runtime:3.0.8 (1564 days without maintenance)

@wing328
Copy link
Member

wing328 commented Apr 13, 2023

@Jacky-code519 thanks for the PR.

@wing328
Copy link
Member

wing328 commented Apr 21, 2023

@Jacky-code519 you will need to update the mustache template instead: https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/JavaJaxRS

@slimming-fat slimming-fat closed this by deleting the head repository Aug 3, 2023
@slimming-fat slimming-fat reopened this Aug 4, 2023
@slimming-fat
Copy link
Author

@Jacky-code519 you will need to update the mustache template instead: https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/JavaJaxRS

@wing328 Can you tell me which specific file is updated?

@wing328
Copy link
Member

wing328 commented Aug 12, 2023

@slimming-fat
Copy link
Author

slimming-fat commented Aug 17, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants