Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERL] Fix bug on test script #12983

Merged

Conversation

thomasphansen
Copy link
Contributor

This fixes a small bug in a perl test script, as mentioned in PR #12871...

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @wing328 @yue9944882

@wing328
Copy link
Member

wing328 commented Jul 23, 2022

The fix looks good and tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/253548183.

Thanks for the contribution. Have a nice weekend.

@wing328 wing328 merged commit 219b32b into OpenAPITools:master Jul 23, 2022
@thomasphansen thomasphansen deleted the th_perl_test_script_bugfix branch July 23, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants