[spring] Add support for request parameter pattern validation #12732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am bean validation in spring codegen
wing328
changed the title
# Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
MelleD
reviewed
Sep 13, 2022
| operationId: headerBeanValidation | ||
| tags: | ||
| - headers | ||
| parameters: |
There was a problem hiding this comment.
A test case with Optional will also be interesting.
There was a problem hiding this comment.
Hi @MelleD , I am not sure I understand, the second header is optional
There was a problem hiding this comment.
No no i mean the java Optional type. That you generate something like
e.g. Optional<@Pattern() String>
There was a problem hiding this comment.
I would personally not use Optional<> for a request header/parameter
There was a problem hiding this comment.
@LubomirS somebody else might use Optional here, so please add a test case for that
borsch
reviewed
Feb 24, 2023
| {{#isHeaderParam}}{{#useBeanValidation}}{{>beanValidationHeaderParams}}{{/useBeanValidation}}{{>paramDoc}} @RequestHeader(value = "{{baseName}}", required = {{#required}}true{{/required}}{{^required}}false{{/required}}{{#defaultValue}}, defaultValue = "{{{.}}}"{{/defaultValue}}){{>dateTimeParam}} {{>optionalDataType}} {{paramName}}{{/isHeaderParam}} |
There was a problem hiding this comment.
why only header parameters? why about request & form parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dation in spring codegen
Support for bean validation annotations for request headers was added in spring codegen, similarly how it currently works for query params. This implements the issue #12726
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.0.1) (patch release),6.1.x(breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente