Skip to content

Conversation

@orrin-naylor-instacart
Copy link

@orrin-naylor-instacart orrin-naylor-instacart commented Apr 25, 2022

Removing barrel exports significantly improves performance in situation where tree shaking is not possible. EG testing via jest. See #12081

Barrel exports are files that import and export a group of files. EG models/index.ts

This does not remove the index files. It just removes the internal dependency on them.

To verify, just make sure all the new imports point to a file that:

  1. Exists
  2. Contains the item being imported

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@lennerd
Copy link

lennerd commented Apr 7, 2025

Why was this closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants