Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpprestsdk] CMake build system improvements #10660

Merged
merged 4 commits into from
Oct 29, 2021

Conversation

srgbtl
Copy link
Contributor

@srgbtl srgbtl commented Oct 22, 2021

  • Use {{packageName}} for client library name
  • Support library installation using cmake

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@wing328
Copy link
Member

wing328 commented Oct 27, 2021

I did a test with the following:

--- a/bin/configs/cpp-restsdk-client.yaml
+++ b/bin/configs/cpp-restsdk-client.yaml
@@ -2,3 +2,5 @@ generatorName: cpp-restsdk
 outputDir: samples/client/petstore/cpp-restsdk/client
 inputSpec: modules/openapi-generator/src/test/resources/2_0/petstore.yaml
 templateDir: modules/openapi-generator/src/main/resources/cpp-rest-sdk-client
+additionalProperties:
+  pacakgeName: CppPetstore

but don't see any changes in the samples samples/client/petstore/cpp-restsdk/.

Can you please take a look when you've time?

@srgbtl
Copy link
Contributor Author

srgbtl commented Oct 28, 2021

I did a test with the following:

--- a/bin/configs/cpp-restsdk-client.yaml
+++ b/bin/configs/cpp-restsdk-client.yaml
@@ -2,3 +2,5 @@ generatorName: cpp-restsdk
 outputDir: samples/client/petstore/cpp-restsdk/client
 inputSpec: modules/openapi-generator/src/test/resources/2_0/petstore.yaml
 templateDir: modules/openapi-generator/src/main/resources/cpp-rest-sdk-client
+additionalProperties:
+  pacakgeName: CppPetstore

but don't see any changes in the samples samples/client/petstore/cpp-restsdk/.

Can you please take a look when you've time?

Done

@wing328
Copy link
Member

wing328 commented Oct 29, 2021

Tested locally and the result is good.

@wing328 wing328 merged commit bf77570 into OpenAPITools:master Oct 29, 2021
@srgbtl srgbtl deleted the cpprest/json branch October 29, 2021 04:42
AndersSpringborg added a commit to Forsteholdet/openapi-generator that referenced this pull request Oct 31, 2021
* OpenAPITools-master: (457 commits)
  [java][jersey2] remove warning using JsonMapper.builder (OpenAPITools#10734)
  update scribejava to 8.x (OpenAPITools#10733)
  [powershell] add file upload support (OpenAPITools#10735)
  Add openapi-generator kotlin article (OpenAPITools#10731)
  [ts-angular]: add ts-ignore directives to avoid compilation errors (OpenAPITools#10713)
  rebalance circleci tests (OpenAPITools#10727)
  [java][okhttp-gson] update dependencies in pom.xml (OpenAPITools#10709)
  [java][jersey2] update plugins in pom.xml (OpenAPITools#10710)
  Fix library generation compatibility with Gradle 7.2 (OpenAPITools#10716)
  [kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class (OpenAPITools#10671)
  [cpprestsdk] CMake build system improvements (OpenAPITools#10660)
  adds get/setHasMultipleTypes to Java schema classes (OpenAPITools#10715)
  update microprofile to newer version (OpenAPITools#10714)
  Typescript saga immutablejs enhancements and small fixes (OpenAPITools#10444)
  add an option for configKey (OpenAPITools#10707)
  Allow specification of configkey for microprofile clients (OpenAPITools#10693)
  Update crystal client gitignore.mustache with shards related files (OpenAPITools#10698)
  Adds ComposedSchema to store schema composed schemas (OpenAPITools#10653)
  Adds setPrettyPrint and the reslver MethodValueResolver.INSTANCE (OpenAPITools#10683)
  [dart] Fix pub server URL (OpenAPITools#10695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants