-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpprestsdk] CMake build system improvements #10660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a test with the following: --- a/bin/configs/cpp-restsdk-client.yaml
+++ b/bin/configs/cpp-restsdk-client.yaml
@@ -2,3 +2,5 @@ generatorName: cpp-restsdk
outputDir: samples/client/petstore/cpp-restsdk/client
inputSpec: modules/openapi-generator/src/test/resources/2_0/petstore.yaml
templateDir: modules/openapi-generator/src/main/resources/cpp-rest-sdk-client
+additionalProperties:
+ pacakgeName: CppPetstore but don't see any changes in the samples Can you please take a look when you've time? |
Done |
Tested locally and the result is good. |
AndersSpringborg
added a commit
to Forsteholdet/openapi-generator
that referenced
this pull request
Oct 31, 2021
* OpenAPITools-master: (457 commits) [java][jersey2] remove warning using JsonMapper.builder (OpenAPITools#10734) update scribejava to 8.x (OpenAPITools#10733) [powershell] add file upload support (OpenAPITools#10735) Add openapi-generator kotlin article (OpenAPITools#10731) [ts-angular]: add ts-ignore directives to avoid compilation errors (OpenAPITools#10713) rebalance circleci tests (OpenAPITools#10727) [java][okhttp-gson] update dependencies in pom.xml (OpenAPITools#10709) [java][jersey2] update plugins in pom.xml (OpenAPITools#10710) Fix library generation compatibility with Gradle 7.2 (OpenAPITools#10716) [kotlin-spring] change the suffix from ".kt" to "Controller.kt" when generating a controller class (OpenAPITools#10671) [cpprestsdk] CMake build system improvements (OpenAPITools#10660) adds get/setHasMultipleTypes to Java schema classes (OpenAPITools#10715) update microprofile to newer version (OpenAPITools#10714) Typescript saga immutablejs enhancements and small fixes (OpenAPITools#10444) add an option for configKey (OpenAPITools#10707) Allow specification of configkey for microprofile clients (OpenAPITools#10693) Update crystal client gitignore.mustache with shards related files (OpenAPITools#10698) Adds ComposedSchema to store schema composed schemas (OpenAPITools#10653) Adds setPrettyPrint and the reslver MethodValueResolver.INSTANCE (OpenAPITools#10683) [dart] Fix pub server URL (OpenAPITools#10695) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{packageName}}
for client library namePR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd