-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Java][Server][Spring] Fix apiNamePrefix and apiNameSuffix usage (issue #8822) #10601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
60bbb9e
to
4dfe0e8
Compare
@@ -744,7 +744,7 @@ public String toApiName(String name) { | |||
return "DefaultApi"; | |||
} | |||
name = sanitizeName(name); | |||
return camelize(name) + "Api"; | |||
return camelize(apiNamePrefix + "_" + name + "_" + apiNameSuffix); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to instead modify DefaultCodegen.java
to have sanitizeName()
and then delete this overidden method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the implications on the other generators, that already exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would sanitize the name, but otherwise I think would behave the same way as it currently does.
@wing328 any thoughts on this?
4dfe0e8
to
4ab8074
Compare
@wing328 Why is the provided fix not merged yet? |
The api prefix option must be added in cliOptions as in the SwiftClient, doesn't it? See: #5567 |
Was fixed yesterday in 50d8e78. |
Not entirely, as the |
Fix #8822
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)