Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript-angular: Added missing semi colon to interface file #10121

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Typescript-angular: Added missing semi colon to interface file #10121

merged 1 commit into from
Aug 10, 2021

Conversation

marleypowell
Copy link
Contributor

@marleypowell marleypowell commented Aug 10, 2021 •
edited by macjohnny
Loading

Fixes #10120
Added missing semi colon to interface export in api.ts template file (typescript-angular).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

@macjohnny
Copy link
Member

Thanks for your contribution. Please re-generate the samples

@marleypowell
Copy link
Contributor Author

@macjohnny I did but as far as I could tell none of the samples included the withInterfaces: true parameter.

macjohnny
macjohnny approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny changed the title fix: 🐛 Added missing semi colon to interface export in api.ts template file (typescript-angular). Typescript-angular: Added missing semi colon to interface export in api.ts template file (typescript-angular). Aug 10, 2021
@macjohnny macjohnny changed the title Typescript-angular: Added missing semi colon to interface export in api.ts template file (typescript-angular). Typescript-angular: Added missing semi colon to interface file Aug 10, 2021
@macjohnny macjohnny merged commit d0788cd into OpenAPITools:master Aug 10, 2021
@marleypowell marleypowell deleted the marley/apis-ts-export-missing-semi-colon branch August 10, 2021 12:06
@wing328 wing328 added this to the 5.2.1 milestone Aug 13, 2021
ekilmer added a commit to ekilmer/openapi-generator that referenced this pull request Aug 16, 2021
@ekilmer
UNTESTED. Merge branch 'master' into inline-resolver.
668a202 
* master: (849 commits)
  Don't use encodeCollectionQueryParameter on maps (OpenAPITools#10116)
  Fixed the utc time issue for httpSigning auth. (OpenAPITools#10139)
  [dart][dio] Update built_value to =>8.1.0 (OpenAPITools#10122)
  Add Inquisico to list of generator users (OpenAPITools#10142)
  add my companies to README (OpenAPITools#10146)
  [C][Client] Allocate memory for the element of array when the type is number (OpenAPITools#10124)
  update samples
  Fixed typo in csharp-netcore httpclient generated code (OpenAPITools#10119)
  Typescript-angular: Added missing semi colon to interface export in `apis.ts` template file. (OpenAPITools#10121)
  Fix issue 10020: [BUG] [typescript-angular] Add "header" to reserved words (OpenAPITools#10091)
  Add missing samples for OpenAPITools#9857
  [typescript] FIX: Generate documentation and examples OpenAPITools#9413 (OpenAPITools#9857)
  Feat adds has discriminator with non empty mapping (OpenAPITools#9667)
  Add switches (authentication collections) to support files (OpenAPITools#9884)
  [dart-dio-next] improve encodeCollectionQueryParameter to handle cases where collectionFormat is null (OpenAPITools#10105)
  [go-server] Feat: add required assertions to models (OpenAPITools#10068)
  [dart2] Include request body on DELETE call (OpenAPITools#10100)
  Make php's array a primitive (OpenAPITools#10093)
  Fix typo (preffer -> prefer) (OpenAPITools#10098)
  Fix typo on rust client (OpenAPITools#10096)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macjohnny macjohnny macjohnny approved these changes

Assignees
No one assigned
Labels
Client: TypeScript
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.

[BUG] Missing semi colon in typescript-angular api.ts template file
3 participants
@marleypowell @macjohnny @wing328