support JAVA_HOME environment variable

[mok-liee]

fixes #661

[mok-liee]

@wing328
this is a next-try of #677

unfortunately it was not possible to create a PR from the same branch, so i had to fork again. the props of course go to @adnbrownie

[mok-liee]

is it possible to run a test locally? i am working on windows with the git-bash.
if i run the unit-test it fails on all because of wrong interpretation of path's slash direction.

i want to get rid of this errors to see exactly whether adjustments to the unit-test are necessary.
i suspect that the modification brings this with it.

[mok-liee]

it looks to me like i can't do anything about the build problem, can i? a manual generate with the versions that throw errors in the log works locally for me.

[wing328]

it looks to me like i can't do anything about the build problem, can i?

one way is to repeat the issue in your fork.

[mok-liee]

I am completly new to Github actions. I will do my best.

[mok-liee]

sorry for messing up this PR but i dont know how to test this build locally. i thought if i do this in my fork this PR is free of my debuggings.

i see that the agent is using /usr/lib/jvm/temurin-11-jdk-amd64 from $JAVA_HOME but the logs are printing out that the executable is not found. i try to figure out more.

[mok-liee]

this build should be successful

[wing328]

@mok-liee thanks. all tests passed.

one more minor request:

can you please update the workflow file to run the build on windows-latest as well: https://github.com/OpenAPITools/openapi-generator-cli/blob/master/.github/workflows/build.yml#L56 so as to ensure changes work in Windows moving forward?

ref: https://stackoverflow.com/a/64036382/677735

[mok-liee]

i will implement this. unfortunately, the weekend will be difficult. i will try next week!

[wing328]

I tried but looks like it will be very difficult as the tests won't work on both windows and linux: #757

e.g.

Object {
        "after": Array [
    -     "Downloaded 4.2.0 to custom storage location /c/w/d/custom/dir",
    +     "Downloaded 4.2.0 to custom storage location D:\\c\\w\\d\\custom\\dir",
        ],
        "before": Array [
          "Download 4.2.0 ...",
        ],
      }

      4[43](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:44) |               await compile();
      [44](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:45)4 |               await fixture.download('4.2.0');
    > 4[45](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:46) |               expect(logMessages).toEqual({
          |                                   ^
      4[46](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:47) |                 before: [chalk.yellow(`Download 4.2.0 ...`)],
      4[47](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:48) |                 after: [
      4[48](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:49) |                   chalk.green(

      at src/app/services/version-manager.service.spec.ts:445:35
      at fulfilled (../../node_modules/tslib/tslib.js:166:[62](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:63))

  ● VersionManagerService › API › download() › the server responds a file › logging › there is a custom storage location › returns /custom/dir for /custom/dir

    expect(received).toEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 1

      Object {
        "after": Array [
    -     "Downloaded 4.2.0 to custom storage location /custom/dir",
    +     "Downloaded 4.2.0 to custom storage location D:\\custom\\dir",
        ],
        "before": Array [
          "Download 4.2.0 ...",
        ],
      }

      443 |               await compile();
      444 |               await fixture.download('4.2.0');
    > 445 |               expect(logMessages).toEqual({
          |                                   ^
      446 |                 before: [chalk.yellow(`Download 4.2.0 ...`)],
      447 |                 after: [
      448 |                   chalk.green(

      at src/app/services/version-manager.service.spec.ts:445:35
      at fulfilled (../../node_modules/tslib/tslib.js:1[66](https://github.com/OpenAPITools/openapi-generator-cli/actions/runs/8128392726/job/22214232230?pr=757#step:6:67):62)

[wing328]

we will get this merged and find another way to test it on windows later with another PR instead

[github-actions]

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀