Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run docker with the --user argument #659

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix: run docker with the --user argument #659

merged 1 commit into from
Sep 5, 2022

Conversation

kageurufu
Copy link
Contributor

This fixes generated clients being owned by root when using runDocker

@wing328
Copy link
Member

wing328 commented Sep 2, 2022

have you reviewed this PR: #654 ?

looks like it's trying to fix the same problem.

can you please give it a try (test it locally) and if it works, we'll merge #654 instead ?

@kageurufu
Copy link
Contributor Author

I had seen #654, but I believe that approach is not usable cross-platform.

wing328
wing328 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. looks like this approach is better

@wing328
Copy link
Member

wing328 commented Sep 4, 2022

This branch is out-of-date with the base branch

can you please merge the latest master into your branch so that i can merge? thanks again for the PR.

@kageurufu
fix: run docker with the --user argument
51b912c 
This fixes generated clients being owned by root when using runDocker
@kageurufu
Copy link
Contributor Author

I rebased out of habit, but its pushed!

@wing328
Copy link
Member

wing328 commented Sep 4, 2022

Thanks. I'll merge it on Monday.

@wing328 wing328 merged commit aa303d0 into OpenAPITools:master Sep 5, 2022
@wing328 wing328 mentioned this pull request Sep 5, 2022
Closed
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kageurufu @wing328