Fixes shell buffer overflow for large input specs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `exec()` function buffers the output of the command executed. When using a large input spec (over 20k lines), the process is terminated due to overflowing the buffer. Increasing the buffer also fixes the issue, but for a generic solution, `spawn()` pipes the output directly without buffering, and behaves just the same with the option `shell: true`.
|
@gervasiocaj thanks for the PR. I'll review and let you know if I've any question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exec()function buffers the output of the command executed.When using a large input spec (over 20k lines), the process is terminated due to overflowing the buffer.
Increasing the buffer also fixes the issue, but for a generic solution,
spawn()pipes the output directly without buffering, and behaves just the same with the optionshell: true.To replicate the error, run
exec(command, { maxBuffer: 1000 })on the petstore example.More info on https://medium.freecodecamp.org/node-js-child-processes-everything-you-need-to-know-e69498fe970a.