Update all dependency and plugin versions #75
Conversation
| import jakarta.validation.ValidatorFactory; | ||
| import jakarta.validation.constraints.Max; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import jakarta.validation.constraints.Size; |
There was a problem hiding this comment.
Hibernate Validator changed from javax to jakarta, so the imports needed to be updated.
There was a problem hiding this comment.
Unfortunately, a lot of projects still use the javax namespace. Thats why this project has ValueExtractors for javax and jakarta. We should support javax at least until Jackson 3, since that is based on Java 17, at which point all projects should have migrated to jakarta.
| <goal>repackage</goal> | ||
| </goals> | ||
| <configuration> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Because this execution is skipped, I don't see how this plugin would be doing anything. I did a build with and without the plugin enabled and didn't see any changes in files.
| <!-- endregion --> | ||
| </properties> | ||
|
|
||
| <dependencyManagement> |
There was a problem hiding this comment.
This section is to aid in the migration away from jackson-base longer term. Instead of relying on the versions provided by the parent, provide the versions ourselves here.
| import jakarta.validation.ValidatorFactory; | ||
| import jakarta.validation.constraints.Max; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import jakarta.validation.constraints.Size; |
There was a problem hiding this comment.
Unfortunately, a lot of projects still use the javax namespace. Thats why this project has ValueExtractors for javax and jakarta. We should support javax at least until Jackson 3, since that is based on Java 17, at which point all projects should have migrated to jakarta.
|
|
||
| <!-- region Dependency Versions --> | ||
| <!-- Validator 8+ requires Java 11, Validator 9+ requires Java 17. --> | ||
| <hibernate-validator.version>7.0.5.Final</hibernate-validator.version> |
There was a problem hiding this comment.
This likely has to be rolled back to 6.x, since that is the last version that supports the javax namespace.
There was a problem hiding this comment.
This and the Jakarta import changes are test only, so I think it’s a safe change to make. The project runtime still allows the consumer to provide whichever (javax or Jakarta) they want to use.
There was a problem hiding this comment.
I took a look at the implementation again and you are right. I thought the implementations were more entangled with the namespace.
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-gpg-plugin</artifactId> | ||
| <version>1.5</version> | ||
| <version>${maven-gpg-plugin.version}</version> |
There was a problem hiding this comment.
this will update gpg plugin to v3.2.8. let's give it try
if it doesn't work, we will revert the upgrade
There was a problem hiding this comment.
Ya I wasn’t really sure how to test it. I’m not familiar with the plugin, but the available options looked the same from what I noticed.
|
@nrayburn-tech thanks for the PR @Til7701 thanks for the review |
|
tests in the master failed (restarted didn't help): https://github.com/OpenAPITools/jackson-databind-nullable/actions/runs/17972102820 can you please take a look when you've time? |
|
#76 should fix this. See https://stackoverflow.com/a/76762846 In the maven release action is a |
|
Yes. I’ll have most of the day tomorrow to work on this project. Just glancing at the error, my guess is jackson-base parent pom has the attach sources configured and so does this project. I haven’t actually confirmed that though. |
3 participants
Ref #74
Ref #64 (personal preference is to close this as not planned, I left a comment on that PR though so it can be discussed there)
Closes #60
Closes #59
Closes #52