Skip to content

fix(attack-path): expand the focused endpoint's finding clusters and reclaim hidden columns' width (#6647) - #6982

Open
Seb-MIGUEL wants to merge 1 commit into
mainfrom
fix/attack-path-focus-expand-and-findings-assets-column
Open

fix(attack-path): expand the focused endpoint's finding clusters and reclaim hidden columns' width (#6647)#6982
Seb-MIGUEL wants to merge 1 commit into
mainfrom
fix/attack-path-focus-expand-and-findings-assets-column

Conversation

@Seb-MIGUEL

Copy link
Copy Markdown
Contributor

Description

Two UX fixes on the attack path view, reported from the chokepoint drill-down flow.

1. Focusing an endpoint now opens its findings straight away. Clicking a chokepoint (from the "Top chokepoints" popover, the table, or the search) rebuilt the graph as the focused endpoint path but left every finding-type cluster collapsed — the analyst had to click each one (portscan, files, credentials…) to see anything. The focused view now pre-expands all of the endpoint's finding-type clusters, fed by a single fetchEndpointFindings call split per type (no extra round-trips versus expanding them by hand).

2. The findings drawer no longer truncates the Assets column. FindingList column widths are percentages of the full six-column table. In compact mode the drawer hides three of them, so Type/Value/Assets only used 57% of the row: the asset chips ellipsized while the right half sat empty. The hidden columns' share is now redistributed over the visible ones, keeping their relative proportions. Full-page usage (no hidden fields) is unchanged.

Follow-up to #6964.

Checks

  • yarn eslint, yarn tsc --noEmit clean.
  • yarn vitest run on the attack-path and findings suites: 27 tests pass.

@github-actions

Copy link
Copy Markdown

/review docs

📖 Docs Reviewer triggered automatically.

2 files changed — 2 functional, 0 documentation.

⚠️ No documentation files modified. Agent will check if doc updates are needed.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.66667% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.94%. Comparing base (3e717ad) to head (29cc84f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ns/simulation/attack_path/SimulationAttackPath.tsx 51.72% 10 Missing and 4 partials ⚠️
...ront/src/admin/components/findings/FindingList.tsx 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (41.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (7.59%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6982      +/-   ##
============================================
- Coverage     44.96%   44.94%   -0.02%     
+ Complexity     9327     9325       -2     
============================================
  Files          2681     2681              
  Lines         80441    80477      +36     
  Branches      12066    12073       +7     
============================================
+ Hits          36168    36171       +3     
- Misses        41653    41681      +28     
- Partials       2620     2625       +5     
Flag Coverage Δ
backend 67.81% <ø> (-0.01%) ⬇️
e2e 17.50% <ø> (-0.40%) ⬇️
frontend 7.59% <41.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant