Skip to content

chore(catalog): add Phishing injector to the marketplace catalog (#6720) - #6766

Open
SamuelHassine wants to merge 1 commit into
mainfrom
chore/catalog-add-phishing-injector
Open

chore(catalog): add Phishing injector to the marketplace catalog (#6720)#6766
SamuelHassine wants to merge 1 commit into
mainfrom
chore/catalog-add-phishing-injector

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Summary

Split from #6721 (one PR per injector, as requested). Adds the Phishing
injector entry (slug openaev_phishing, image openaev/injector-phishing, container_type INJECTOR,
container_version "rolling") to the marketplace catalog
(openaev-api/src/main/resources/catalog/catalog-integrators.json) so it
shows up in the in-product marketplace.

Details

  • Title, description, short description, use cases, subscription link and
    slug are taken from the injector's manifest-metadata.json in
    injectors-python. The slug matches the canonical injector_type declared
    in the injector's config loader.
  • config_schema copies the standard base block from existing INJECTOR
    entries (OPENAEV_URL, OPENAEV_TOKEN, OPENAEV_TENANT_ID, INJECTOR_ID,
    INJECTOR_NAME, INJECTOR_LOG_LEVEL) and then adds the injector-specific keys derived from the injector's own config: PHISHING_PUBLIC_URL, PHISHING_LISTEN_HOST, PHISHING_LISTEN_PORT, PHISHING_REDIRECT_URL, PHISHING_SMTP_HOST, PHISHING_SMTP_PORT, PHISHING_SMTP_USERNAME, PHISHING_SMTP_PASSWORD (password), PHISHING_SMTP_USE_TLS and PHISHING_MAIL_FROM.
  • Consistency flags match the existing injector entries: verified true,
    manager_supported true, playbook_supported false, max_confidence_level 80.
  • The entry is inserted at a unique position in the contracts array so the
    11 split PRs merge conflict-free in any order (entry order in the catalog
    is not semantic).

Test plan

  • catalog-integrators.json parses as valid JSON (Python json.loads).
  • Diff is a single added entry; no existing entry is removed, reordered or
    altered.
  • The entry satisfies the ingestion parser
    (CatalogConnectorIngestionService): types/formats map to the supported
    enums; password fields use format: password + writeOnly.

Part of #6720

Copilot AI review requested due to automatic review settings July 18, 2026 04:31
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jul 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the Phishing injector contract (slug: openaev_phishing, image openaev/injector-phishing) to the in-product marketplace catalog so it can be discovered and configured from OpenAEV.

Changes:

  • Appends a new INJECTOR contract entry for Phishing with metadata (title/description/use cases/versioning flags).
  • Defines a config_schema that includes the standard OpenAEV/Injector base keys plus phishing-specific SMTP/tracking-server settings, including a format: password + writeOnly secret field.
  • Adds an embedded base64 PNG logo for the catalog entry.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.38%. Comparing base (e21d32a) to head (f56f80e).

❌ Your project check has failed because the head coverage (2.93%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6766      +/-   ##
============================================
+ Coverage     45.33%   45.38%   +0.05%     
  Complexity     8029     8029              
============================================
  Files          2364     2364              
  Lines         66751    66751              
  Branches       9033     9033              
============================================
+ Hits          30260    30294      +34     
+ Misses        34513    34468      -45     
- Partials       1978     1989      +11     
Flag Coverage Δ
backend 67.63% <ø> (ø)
e2e 18.47% <ø> (+1.10%) ⬆️
frontend 2.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants