Skip to content

Comments

[backend] fix: add orphanRomoval parameter for Scenarion/inject relat…#4968

Draft
heditar wants to merge 3 commits intorelease/currentfrom
fix/bug-scenario-deletion
Draft

[backend] fix: add orphanRomoval parameter for Scenarion/inject relat…#4968
heditar wants to merge 3 commits intorelease/currentfrom
fix/bug-scenario-deletion

Conversation

@heditar
Copy link
Contributor

@heditar heditar commented Feb 17, 2026

…ionship

Proposed changes

  • Spring upgrade created a bug that was throwing an error while trying to delete a scenario/simulation. This PR fix this issue by adding cascade = CascadeType.REMOVE orphanRemoval = true to the relationship

Testing Instructions

  1. Create a scenario/simulation, add an inject, delete ii -> it should succeed

Related issues

  • Product testing bug

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • [NA] I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.57%. Comparing base (c48c40e) to head (a3466a3).
⚠️ Report is 20 commits behind head on release/current.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4968      +/-   ##
=====================================================
+ Coverage              56.54%   56.57%   +0.03%     
- Complexity              4472     4615     +143     
=====================================================
  Files                    991     1002      +11     
  Lines                  29665    30329     +664     
  Branches                2167     2236      +69     
=====================================================
+ Hits                   16775    17160     +385     
- Misses                 11932    12203     +271     
- Partials                 958      966       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant