Skip to content

Conversation

@antoinemzs
Copy link
Member

@antoinemzs antoinemzs commented Nov 26, 2025

Proposed changes

  • Add source column to ConnectorInstance
  • Default to "OTHER"; this value should be used as default so that inserts from other subsystems than the catalog or the properties migration mechanism don't imply that they were originated from the catalog or a migration

Testing Instructions

  1. normal CRUD

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs changed the base branch from master to release/current November 26, 2025 15:56
@antoinemzs antoinemzs changed the title Feature/source column for connector instance [backend] feature(composer) : source column for connector instance (#4313) Nov 26, 2025
@antoinemzs antoinemzs changed the title [backend] feature(composer) : source column for connector instance (#4313) [backend] feat(composer) : source column for connector instance (#4313) Nov 26, 2025
@antoinemzs antoinemzs changed the title [backend] feat(composer) : source column for connector instance (#4313) [backend] feat(composer): source column for connector instance (#4313) Nov 26, 2025
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.39%. Comparing base (04e2e56) to head (883de8c).

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4440      +/-   ##
=====================================================
- Coverage              50.39%   50.39%   -0.01%     
- Complexity              3721     3722       +1     
=====================================================
  Files                    912      913       +1     
  Lines                  27301    27305       +4     
  Branches                2046     2046              
=====================================================
+ Hits                   13758    13760       +2     
- Misses                 12707    12709       +2     
  Partials                 836      836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs merged commit cb2c74c into release/current Dec 5, 2025
11 checks passed
@antoinemzs antoinemzs deleted the feature/source_column_for_connector_instance branch December 5, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants