Update key makefile #308
Merged
Update key makefile #308
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrfarmer
requested changes
Jan 30, 2026
Collaborator
hrfarmer
left a comment
hrfarmer
left a comment
There was a problem hiding this comment.
just for clarity that it's different from the signing key
Co-authored-by: aychar <aychar@aychar.dev>
hrfarmer
approved these changes
Jan 30, 2026
Comment on lines
+134
to
+135
| .PHONY: copy-keys | ||
| copy-keys: |
Collaborator
There was a problem hiding this comment.
If you remove the PHONY declaration and name the target keys/proves.pem it will only run if that file doesn't exist. This means that you can set this target to run automatically during the build step and remove the readme guidance.
Suggested change
| .PHONY: copy-keys | |
| copy-keys: | |
| keys/proves.pem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update key makefile
Description
Adding copying local keys to make and changing the readme accordingly
How Has This Been Tested?
Checklist
Further Notes / Considerations