-
Notifications
You must be signed in to change notification settings - Fork 1
Added Ground station updates, also fixed linux hanging problem #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Makefile build system with improved logging, refined installation process, and ground station support. The changes focus on making the build process more transparent and user-friendly.
- Adds detailed progress messages throughout the build and library download processes
- Refactors library installation to use temporary directories and line-by-line processing
- Adds support for ground station-specific package installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes result in a pretty significant performance decrease.
Times testing on Windows:
Main
make download-libraries: 25s
make build: 31s
PR #9
make download-libraries: 1m27s
make build: 1m30s
Not an expert on this, but it would seem to be because you are pip installing all of the dependencies one at a time rather than in parallel. I'm fine with merging in the ground station bump, but we should rethink how we are addressing the linux compatability changes
|
@Mikefly123 Would it be worth just making separate make commands (make download-libraries-linux) or smth so mac users and most users and do the general commands, but when a linux user runs into the issue they can call these specific funtions? The installing one at at time is what is making it work consistently in LINUX, but is also not needed all the time, just when there are large changes |
|
@ineskhou sure yeah I think we can split the commands. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ation/CircuitPython_RP2350_v5d into Makefile_Updates
Summary
Two changes to the Makefile in this PR
How was this tested