Skip to content

Conversation

@ineskhou
Copy link

@ineskhou ineskhou commented Nov 3, 2025

Summary

Two changes to the Makefile in this PR

  1. Since we moved the ground station back to pysqured, it downloads the correct folder from pysquared
  2. It has changes to make download-libraries cleaner. In linux, I've been having issues downloading libraries when there have been changes or when I switch branches. This Makefile now has much more verbose output to see what is downloading. There is also now a functionality where it builds to a temp folder and those temp folder to target, as it was often locking on my computer

How was this tested

  • Added new unit tests
  • Ran code on hardware (screenshots are helpful)
  • Ran make commands and checked correct files were being downloaded

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Makefile build system with improved logging, refined installation process, and ground station support. The changes focus on making the build process more transparent and user-friendly.

  • Adds detailed progress messages throughout the build and library download processes
  • Refactors library installation to use temporary directories and line-by-line processing
  • Adds support for ground station-specific package installation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@Mikefly123 Mikefly123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes result in a pretty significant performance decrease.

Times testing on Windows:
Main
make download-libraries: 25s
make build: 31s

PR #9
make download-libraries: 1m27s
make build: 1m30s

Not an expert on this, but it would seem to be because you are pip installing all of the dependencies one at a time rather than in parallel. I'm fine with merging in the ground station bump, but we should rethink how we are addressing the linux compatability changes

@ineskhou
Copy link
Author

ineskhou commented Nov 4, 2025

@Mikefly123 Would it be worth just making separate make commands (make download-libraries-linux) or smth so mac users and most users and do the general commands, but when a linux user runs into the issue they can call these specific funtions?

The installing one at at time is what is making it work consistently in LINUX, but is also not needed all the time, just when there are large changes

@Mikefly123
Copy link

@ineskhou sure yeah I think we can split the commands.

ineskhou and others added 5 commits November 5, 2025 14:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ation/CircuitPython_RP2350_v5d into Makefile_Updates
@ineskhou ineskhou requested a review from Mikefly123 November 5, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants