Add pagination and delete functionality to Export Modal (#93) #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #93 The Export Modal was missing pagination fetchMore functionality and delete button mutations. This commit adds full delete functionality and verifies pagination is working. Changes: - Added DELETE_EXPORT GraphQL mutation to frontend mutations.ts - Updated ExportItemRow to pass item.id to onDelete handler - Implemented handleDelete in ExportModal using useMutation - Added confirmation dialog before deletion - Added toast notifications for success/error states - Refetch exports list after successful deletion - Show loading state during deletion Pagination: - ExportList already had FetchMoreOnVisible component implemented - fetchMore handler already properly configured with cursor/limit - GET_EXPORTS query already supports pagination parameters - Pagination should work as expected with existing implementation All TypeScript compilation passes successfully.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: JSIV <5049984+JSv4@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
DELETE_EXPORTGraphQL mutation to frontend mutations.tsExportItemRowto pass item.id to onDelete handlerhandleDeletein ExportModal using useMutationPagination
Test Plan