Skip to content

Conversation

@JSv4
Copy link
Collaborator

@JSv4 JSv4 commented Apr 27, 2025

To derisk big upgrade of pdf.js, I wanted Playwright coverage to ensure basic functionality didn't break. This was a lot easier with Vite. So this PR:

  1. Adds Vite
  2. Adds Playwright and basic test for DocumentKnowledgeBase.tsx
  3. Upgrades pdf.js

@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (9744b94) to head (dfd0f1e).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         280      280           
  Lines       12816    12816           
=======================================
  Hits        11530    11530           
  Misses       1286     1286           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9744b94...dfd0f1e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSv4 JSv4 changed the title Migrate to Vie & Upgrade Pdf.js Migrate to Vite & Upgrade Pdf.js Apr 27, 2025
@JSv4 JSv4 merged commit a6b416a into main May 6, 2025
7 checks passed
@JSv4 JSv4 deleted the JSv4/upgrade-pdfjs branch May 6, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants