-
-
Notifications
You must be signed in to change notification settings - Fork 115
Relationship Import for Parser Pipeline #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nships ARE proeprly imported.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 89.62% 90.00% +0.38%
==========================================
Files 220 226 +6
Lines 7826 8076 +250
==========================================
+ Hits 7014 7269 +255
+ Misses 812 807 -5 ☔ View full report in Codecov by Sentry. |
…to import from analyzers and attach to analysis. Added some more convenient releated_name props.
…ility flags to work more sensibly with relations.
…ometimes this is amazing and sometimes does really odd things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On reflection of existing components and workflows, it will be much easier (And probably more correct) to create parent child links as relationship objects. While we have a number of features to render and support this on the frontend, the backend was not actually importing or exporting relationships in our corpus exports. Updated base dict definitions and added importing utils and tests.