-
Notifications
You must be signed in to change notification settings - Fork 34
Adding transient solver #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wdhawkins
wants to merge
5
commits into
Open-Sn:main
Choose a base branch
from
wdhawkins:transient
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50d9da2 to
661e9f8
Compare
andrsd
requested changes
Jan 31, 2026
| InputParameters params = Solver::GetInputParameters(); | ||
| params.SetGeneralDescription("Generalized implementation of a transient k-eigenvalue solver"); | ||
| params.ChangeExistingParamToOptional("name", "TransientKEigenSolver"); | ||
| params.AddRequiredParameter<std::shared_ptr<Problem>>("problem", "An existing lbs problem"); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lbs problem-> discrete ordinates problem (ctor downcast to DiscreteOrdinatesProblem)
ragusa
reviewed
Jan 31, 2026
…lve. Adding initialization from arbitrary solvers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
TransientSolver. It is very loosely based onTransientKEigenSolverby @zachhardy.TransientSolverhas two modes controlled by theinitial_stateparameter:existingandzero. Inexistingmode, the transient solver evolves the solution of a previous solver. For example, to evolve the solution of a k-eigenvalue problem, one might do:or, to evolve the solution of a steady-state problem:
In
zeromode, the transient solver starts from a zero initial state and evolves the solution:A number of examples are given in the
transport_transientregression input folder.This is a bit of a large commit. I tried to make it as small as possible by committing the time-dependent work in other commits, but it's still quite large.
Resolves #57
Resolves #58