DRAFT: Implementation of Galerkin Quadrature methods #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggie04
changed the title
ragusa
requested review from
andrsd,
quocdang1998 and
wdhawkins
and removed request for
andrsd and
quocdang1998
quocdang1998
requested changes
Sep 19, 2025
Comment on lines
117
to
172
| angular_quadrature.def( | ||
| "GetDiscreteToMomentOperator", | ||
| [](const AngularQuadrature& self) { | ||
| const auto& op = self.GetDiscreteToMomentOperator(); | ||
| // Convert to list of lists for Python | ||
| py::list result; | ||
| for (const auto& row : op) { | ||
| py::list py_row; | ||
| for (double val : row) { | ||
| py_row.append(val); | ||
| } | ||
| result.append(py_row); | ||
| } | ||
| return result; | ||
| }, | ||
| "Get the discrete-to-moment operator as a list of lists." | ||
| ); | ||
| angular_quadrature.def( | ||
| "GetMomentToDiscreteOperator", | ||
| [](const AngularQuadrature& self) { | ||
| const auto& op = self.GetMomentToDiscreteOperator(); | ||
| // Convert to list of lists for Python | ||
| py::list result; | ||
| for (const auto& row : op) { | ||
| py::list py_row; | ||
| for (double val : row) { | ||
| py_row.append(val); | ||
| } | ||
| result.append(py_row); | ||
| } | ||
| return result; | ||
| }, | ||
| "Get the moment-to-discrete operator as a list of lists." | ||
| ); |
Collaborator
There was a problem hiding this comment.
Similarly, these functions are not necessary to be exported to Python.
And if you really need to export it, you should export this as a NumPy array The results of these methods are matrices, not lists of lists.
Author
There was a problem hiding this comment.
I'm leaving these in for now (updated to be numpy arrays), mostly because I am interested in the structure of the two matrices. If it's preferred to just have it be accessible through direct manipulation of the C++ code, I can remove it.
| : type_(type), | ||
| dimension_(dimension), | ||
| scattering_order_(scattering_order), | ||
| construction_method_(method) |
Collaborator
There was a problem hiding this comment.
Since you add the construction_method_ to the constructor, don't forget to update the constructor of derived classes as well.
AndrewNJ03
force-pushed
the
galerkinQuadratureMethods
branch
2 times, most recently
from
43e64a0 to
83b5966
Compare
AndrewNJ03
force-pushed
the
galerkinQuadratureMethods
branch
from
4dcc5f5 to
9ec1483
Compare
AndrewNJ03
force-pushed
the
galerkinQuadratureMethods
branch
from
1c49ae4 to
53b5d05
Compare
AndrewNJ03
force-pushed
the
galerkinQuadratureMethods
branch
from
6549aa4 to
80be68b
Compare
3 new angular quadrature types have been introduced, along with corresponding regression tests. 2D Lebedev, a modification of its 3D variant, as well as 2D and 3D GLC Triangular Sets.
Removed GQ2. Removed building D2M and M2D from python binding. Changed D2M/M2D constructors to internally handle methods instead of unique constructors. Moved InvertMatrix method to math.cc for general usage. Optimization changes were made. Added OrthogonalizeHouseholder method. Added basis for GQ3 method. New harmonic_selection_rules file to contain and house the various rules of quadratures.
Cross sections do not yet see the correct moment orders.
Functionality for the process is complete. Works for Lebedev and LDFE sets up to a given limit. Additionally works for Product Quadrature Squares. There are still some minor changes that need to be made, a few random lebedev order's don't have emperically derived harmonic sets yet.
nb_dir -> num_dir
AndrewNJ03
force-pushed
the
galerkinQuadratureMethods
branch
from
e157729 to
92ca94f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the Galerkin Quadrature methods 1, 2, and 3 into OpenSn to offer another option when forming the scattering source.