Don't store node-averaged values as elemental field for discontinuous solutions #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrsd
added
bug-fix
ragusa
reviewed
Aug 28, 2025
Contributor
ragusa
left a comment
ragusa
left a comment
There was a problem hiding this comment.
if this PR goes through, will the vtu file still contain the cellwise material blockID in a correct fashion. Just wondering if the same function is used to output the blockID (and also partition ID, by the way) inside the solution output
Collaborator
Author
Yes. It is done in a completely independent code path |
Collaborator
Author
|
And the partition IDs are stored here - which this PR does not touch. So all should be as expected... |
ragusa
approved these changes
Aug 29, 2025
Contributor
ragusa
left a comment
ragusa
left a comment
There was a problem hiding this comment.
This change may affect the OpenSnExamples repo as well
wdhawkins
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372