Adding Classic Richardson WGS Solver #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdhawkins
force-pushed
the
classic_richardson
branch
from
d153a64 to
3ab2a38
Compare
wdhawkins
force-pushed
the
classic_richardson
branch
from
b08be03 to
e8d46b1
Compare
andrsd
reviewed
Jul 18, 2024
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.cc
Outdated
Show resolved
Hide resolved
andrsd
requested changes
Jul 18, 2024
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Outdated
Show resolved
Hide resolved
wdhawkins
force-pushed
the
classic_richardson
branch
from
e8d46b1 to
d23112f
Compare
ragusa
reviewed
Jul 30, 2024
...es/linear_boltzmann_solvers/discrete_ordinates_solver/iterative_methods/sweep_wgs_context.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Show resolved
Hide resolved
...les/linear_boltzmann_solvers/transport_steady/transport_3d_5_cycles_2_classic_richardson.lua
Outdated
Show resolved
Hide resolved
...linear_boltzmann_solvers/transport_steady/transport_3d_2_unstructured_classic_richardson.lua
Outdated
Show resolved
Hide resolved
...linear_boltzmann_solvers/transport_steady/transport_3d_2_unstructured_classic_richardson.lua
Outdated
Show resolved
Hide resolved
...linear_boltzmann_solvers/transport_steady/transport_3d_2_unstructured_classic_richardson.lua
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.cc
Outdated
Show resolved
Hide resolved
wdhawkins
force-pushed
the
classic_richardson
branch
from
d23112f to
551dbfa
Compare
andrsd
approved these changes
Aug 5, 2024
zhardy-lanl
requested changes
Aug 6, 2024
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.cc
Outdated
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/lbs_iterative_methods.h
Show resolved
Hide resolved
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Show resolved
Hide resolved
...dules/linear_boltzmann_solvers/transport_keigen/keigenvalue_transport_3d_openmcxs_UO2_cr.lua
Show resolved
Hide resolved
ragusa
approved these changes
Aug 14, 2024
andrsd
requested changes
Aug 19, 2024
modules/linear_boltzmann_solvers/lbs_solver/iterative_methods/classic_richardson.h
Show resolved
Hide resolved
wdhawkins
force-pushed
the
classic_richardson
branch
from
551dbfa to
6a1f3d4
Compare
wdhawkins
force-pushed
the
classic_richardson
branch
from
6a1f3d4 to
79ca332
Compare
zhardy-lanl
approved these changes
Aug 29, 2024
Collaborator
zhardy-lanl
left a comment
zhardy-lanl
left a comment
There was a problem hiding this comment.
Thanks for the changes! Some of the more fine grained details should be hashed out in future PRs when we change LBS solver.
Collaborator
Author
Yes, I really would like to see the convergence checks pulled out into stand-alone routines. I have an upcoming PR that does something similar for LBS io, so it might be a pattern that we can use for convergence checking. |
andrsd
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a WGS solver based on Classic Richardson. This class is not derived from WGSLinearSolver since it does not depend on PETSc with the exception of whatever the preconditioners do. Resolves #22.
Moving forward, it might make sense to rename this to WGSClassicRicardsonSolver and rename the current WGSLinearSolver to WGSPETScSolver or something similar. Thoughts?