Fix issue with confirmation dialog being blocked#291
Merged
ge0rdi merged 1 commit intoOpen-Shell:masterfrom Feb 8, 2020
Merged
Fix issue with confirmation dialog being blocked#291ge0rdi merged 1 commit intoOpen-Shell:masterfrom
ge0rdi merged 1 commit intoOpen-Shell:masterfrom
Conversation
Member
Author
|
Fix was confirmed to work. See linked issue. |
Member
Author
|
This PR causes #295. |
Delete confirmation dialog may be (partially) hidden behing start menu. As a result the dialog may be not accessible because start menu(s) are displayed as top-most windows. Thus when executing menu command we will make menu(s) non-topmost. So that other windows can be drawn on top of menu(s). Fixes Open-Shell#257
ge0rdi
force-pushed
the
fix-topmost-issue
branch
from
efe1bc0 to
7aaab25
Compare
Member
Author
|
#295 is fixed now. I will keep this open for a while to see if there will be some more reports. |
|
No further issues to report with this build. |
Member
Author
|
@Gittyperson |
|
close ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete confirmation dialog may be (partially) hidden behing start menu.
As a result the dialog may be not accessible because start menu(s) are
displayed as top-most windows.
Thus when executing menu command we will make menu(s) non-topmost. So that
other windows can be drawn on top of menu(s).
Fixes #257