Properly scale default skin font according to DPI (#1110) #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original fix introduced in 528d15 was not correct. The problem is that `SystemParametersInfo` uses DPI that current session started with. We should use `SystemParametersInfoForDpi` (available since Win10 1607) that returns properly scaled font size. Fixes #1110
|
Looks good on both Win11 insider and Win10 22H2. So I assume older Windows versions will have the same behavior as before 05779ca ? |
bonzibudd
approved these changes
Jan 19, 2023
Yup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original fix introduced in 528d15 was not correct. The problem is that
SystemParametersInfouses DPI that current session started with.We should use
SystemParametersInfoForDpi(available since Win10 1607) that returns properly scaled font size.Fixes #1110