fix(updater): discover modern Beta release tags

[appergb]

User description

Summary

• recognize the current vX.Y.Z-Beta.N-tauri release-tag convention when reading the GitHub Releases Atom feed
• preserve discovery of historical *-beta-tauri releases
• cover desktop selection and Android manifest URL composition with regressions that prefer v1.3.15-Beta.1-tauri over the obsolete v1.3.10-4-beta-tauri
• align RELEASING.md with the modern Beta tag convention

Root cause

The shared Atom parser only accepted tags ending in lowercase -beta-tauri. Current releases use -Beta.N-tauri, so desktop and Android skipped every recent Beta entry and selected the last legacy release still present in the feed.

Validation

• RED: both new focused tests failed with actual v1.3.10-4-beta-tauri vs expected v1.3.15-Beta.1-tauri
• GREEN: both focused tests pass after the shared parser fix
• cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml --lib — 726 passed
• cargo test --manifest-path openless-all/app/src-tauri/backend-tests/Cargo.toml — 119 passed
• npm test — aggregate runner passed all 22 discovered frontend/contract tests
• cargo check --manifest-path openless-all/app/src-tauri/Cargo.toml
• cargo audit --file openless-all/app/src-tauri/Cargo.lock — no vulnerabilities; 18 allowed upstream maintenance/unsoundness warnings
• npm audit — 0 vulnerabilities
• npm run build
• changed Rust files formatted with rustfmt; git diff --check passed
• gitleaks scanned the exact commit with no leaks
• current beta merge-tree passed cleanly against 664633f32d8d877510db25ec9d37e8b49e54d918

Scope

No UI changes, version bump, tag, release, or release-workflow trigger.

---

PR Type

Bug fix, Enhancement

---

Description

• Recognize modern vX.Y.Z-Beta.N-tauri tag format in Atom feed parser

• Preserve backward compatibility with legacy *-beta-tauri suffix

• Reject malformed modern tags (invalid version or beta number)

• Update unit tests for desktop and Android, and document new convention

---

Diagram Walkthrough

flowchart LR
  A[Atom Feed] --> B(parse_latest_beta_from_atom)
  B --> C{is_beta_release_tag}
  C -->|Legacy -beta-tauri| D[Accept]
  C -->|Modern -Beta.N-tauri| E[Validate version & beta number]
  E --> F[Accept]
  E --> G[Skip]
  D --> H[Return latest release]
  F --> H

Loading

File Walkthrough

	Relevant files
Enhancement	settings.rs Add is_beta_release_tag validation function                            openless-all/app/src-tauri/src/commands/settings.rs Added is_beta_release_tag function to validate both legacy and modern beta tag formats Updated parse_latest_beta_from_atom to use the new function Added validation to reject malformed modern tags (e.g., missing version parts, non-digit beta number) Updated doc comments to reflect new tag convention +29/-4
Tests	mod.rs Add unit tests for modern beta tag detection                          openless-all/app/src-tauri/src/commands/mod.rs Added test parse_latest_beta_from_atom_prefers_modern_beta_tag_over_legacy_beta Added test parse_latest_beta_from_atom_skips_malformed_modern_tags +51/-0    updater_logic.rs Add Android beta URL tests with modern tags                            openless-all/app/src-tauri/src/android/updater_logic.rs Added test beta_manifest_urls_use_newest_modern_beta_tag_from_atom Added test beta_manifest_urls_skip_malformed_modern_tags_from_atom +41/-0
Documentation	RELEASING.md Update RELEASING.md with modern beta tag convention            RELEASING.md Updated beta release tag format to vX.Y.Z-Beta.-tauri Noted backward compatibility with historical *-beta-tauri suffix Updated version bump script instructions for prerelease versions +6/-3

---

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit e21c124)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[appergb]

Logical verdict: REQUEST_CHANGES (submitted as a COMMENTED review).

Fresh review of exact head 13c40b4b21fb8f95ae49352a575510f2959cbfa0 against live beta 664633f32d8d877510db25ec9d37e8b49e54d918.

Required finding — validate the complete modern tag shape, not only its tail:

• is_beta_release_tag in openless-all/app/src-tauri/src/commands/settings.rs:530-538 discards everything before the last -Beta. and validates only a non-empty numeric suffix plus -tauri. An exact probe of the committed predicate accepts v-Beta.1-tauri, garbage-Beta.1-tauri, -Beta.1-tauri, and v1.3.15-Beta.2-Beta.1-tauri, although the updated release policy defines the modern form as v<X.Y.Z>-Beta.<N>-tauri.
• This is observable updater behavior, not just naming hygiene: parse_latest_beta_from_atom returns the first accepted feed entry. A newer malformed release would therefore preempt the valid Beta entry, and both desktop and Android would compose manifest endpoints from the malformed tag (typically producing 404s and hiding the real update).
• The new tests cover the positive modern form, historical lowercase form, stable exclusion, and modern-before-legacy ordering, but none places a malformed newer *-Beta.*-tauri candidate before a valid Beta. Tighten the modern branch to the documented complete shape and add positive/negative ordering cases. Preserve the historical lowercase forms intentionally rather than removing compatibility.

What is correct and independently verified:

• The RED/GREEN behavior is real. A source-equivalent probe against the live appergb/openless Atom feed selects obsolete v1.3.10-4-beta-tauri with beta's predicate and current v1.3.14-Beta.3-tauri with the head predicate. On the committed head, both focused tests pass; the Android test calls the shared crate::commands::parse_latest_beta_from_atom and then checks both manifest URLs use v1.3.15-Beta.1-tauri.
• Desktop reaches that parser through fetch_latest_beta_release and resolve_beta_manifest_endpoints; Android's production check_update calls the same fetch/parser and passes its tag to beta_manifest_urls. Exact-head Android target cargo check passed.
• Valid stable tags such as v1.3.15-tauri are rejected. Current modern tags and actual legacy lowercase tags are accepted; malformed/incorrect case, empty or nonnumeric Beta numbers, missing -tauri, and trailing text are rejected. The required gap is validation of the version/prefix portion.
• RELEASING.md's v<X.Y.Z>-Beta.<N>-tauri policy matches the release workflow's modern Beta classification, prerelease handling, Beta manifest naming, Windows MSI skip, and stable-only Homebrew exclusion. It also correctly retains the historical lowercase compatibility note.

Verification:

• Head is one commit ahead / zero behind beta; merge base is beta. The conflict-free merge tree 97130d9e330b8e9bdbe8a280d1cd9c177f8de031 exactly equals the head tree.
• Clean detached merge-result worktree: focused tests 2/2, full Rust library 726/726, Rust-only backend 119/119, aggregate npm test 22/22, frontend production build, and cargo check all passed.
• Exact-head CI is five green. macOS ran both new tests and 726 Rust tests; Linux ran both new tests and 689 cfg-specific tests; Windows compiled the full lib-test binary, ran 130 Rust-only tests, and passed the 22-test aggregate; Android compiled the production Android target. Version sync passed on desktop jobs.
• npm audit: 0 vulnerabilities. cargo audit: exit 0 with 18 allowed upstream warnings. Exact-commit gitleaks: no leaks. git diff --check: passed.
• Whole-file rustfmt --check still reports unrelated pre-existing formatting differences in settings.rs and commands/mod.rs; the same differences are present on beta and none intersects the added hunks. updater_logic.rs and all added Rust hunks are rustfmt-conformant.
• No UI, style, dependency, version, tag, release, or workflow file is changed.

Final drift check immediately before this review: head remains 13c40b4b21fb8f95ae49352a575510f2959cbfa0; beta remains 664633f32d8d877510db25ec9d37e8b49e54d918; all five exact-head checks remain green.

[github-actions]

Persistent review updated to latest commit e21c124

[appergb]

Logical verdict: APPROVE (submitted as a fresh COMMENTED review).

Fresh independent review of exact head e21c124fe5a3e3256c73ea8c343052fa9b0730ca against live beta 664633f32d8d877510db25ec9d37e8b49e54d918. I did not reuse the old head's CI or review evidence. No blocking findings remain.

The prior malformed-prefix blocker is closed:

• The modern branch now requires the complete documented shape: leading v, exactly three non-empty ASCII-numeric version components, exact -Beta., a non-empty ASCII-numeric release number, and exact -tauri termination. The historical lowercase *-beta-tauri compatibility path remains intentionally unchanged.
• A fresh source-equivalent predicate probe reproduced the old head accepting malformed prefixes, then confirmed this head rejects all 13 malformed modern shapes exercised by the regression matrix while accepting v1.3.15-Beta.1-tauri and the real legacy form v1.3.10-4-beta-tauri and rejecting stable tags.
• parse_latest_beta_from_atom_skips_malformed_modern_tags places malformed prefix, version, number, suffix, and repeated-marker candidates before the valid entry, so it verifies skip/order behavior rather than a positive match in isolation. The Android regression calls the same shared parser and verifies both generated manifest URLs use the valid tag.

No new edge-case regression found:

• Desktop still reaches the shared parser through fetch_latest_beta_release and its Beta endpoint resolver; Android production check_update uses the same fetch/parser result and passes the validated tag to beta_manifest_urls.
• The current live release feed orders stable v1.3.14-tauri, modern v1.3.14-Beta.3-tauri, and historical v1.3.10-4-beta-tauri; the corrected predicate skips the stable entry, accepts the current modern release, and preserves the historical fallback.
• RELEASING.md's v<X.Y.Z>-Beta.<N>-tauri policy remains aligned with the release workflow's Beta prerelease classification, Beta-only manifest naming, Windows MSI skip, and stable-only Homebrew gate.

Fresh exact-head verification:

• Clean detached worktree: focused parser/Android regressions 4/4, full Rust library 728/728, Rust-only backend 119/119, aggregate frontend/contract suite 22/22, production frontend build, and cargo check all passed.
• Exact-head CI is five green. macOS ran all four new cases and 728/728 Rust tests; Linux ran all four and 691/691 cfg-specific tests; Windows compiled the full lib-test target and passed 130/130 Rust-only tests; Android compiled the production aarch64-linux-android target. The 22-test aggregate and five-file version-sync gate passed on all desktop jobs; PR-Agent also passed.
• npm audit: 0 vulnerabilities. cargo audit: exit 0 with 18 allowed upstream warnings. Gitleaks scanned the exact two-commit range with no leaks. git diff --check passed.
• Whole-file rustfmt --check still reports unrelated existing formatting differences outside every changed hunk in settings.rs and commands/mod.rs; updater_logic.rs and all added hunks are rustfmt-conformant.

Final drift check immediately before this review: head remains e21c124fe5a3e3256c73ea8c343052fa9b0730ca; beta remains 664633f32d8d877510db25ec9d37e8b49e54d918; head is zero behind / two ahead; merge base is beta; the conflict-free merge tree 01131665925a1b1969d567c3b74a8f15194c57aa exactly equals the head tree; all five exact-head checks remain green.