Skip to content

fix(cask): update Homebrew package to v1.3.14#802

Merged
appergb merged 2 commits into
betafrom
fix/issue-766-homebrew-cask
Jul 14, 2026
Merged

fix(cask): update Homebrew package to v1.3.14#802
appergb merged 2 commits into
betafrom
fix/issue-766-homebrew-cask

Conversation

@appergb

@appergb appergb commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

User description

Summary

  • update the Homebrew Cask from the unavailable v1.3.12-tauri release to the current stable v1.3.14-tauri release
  • set the arm64 and Intel SHA-256 values to the digests verified from the published DMG assets
  • declare macOS Monterey as the minimum supported system, matching LSMinimumSystemVersion=12.0 in both DMGs
  • keep the Cask description compliant with Homebrew style rules

Verification

  • ruby -c Casks/openless.rb
  • brew audit --cask --strict review802/openless/openless in a temporary local tap
  • brew readall --aliases --os all --arch all review802/openless
  • brew style --cask review802/openless/openless
  • brew fetch --cask --all-platforms --force --retry review802/openless/openless
  • brew livecheck --cask review802/openless/openless (1.3.14 ==> 1.3.14)
  • downloaded and verified both DMGs with hdiutil verify; both app bundles report LSMinimumSystemVersion=12.0
  • independently verified both SHA-256 digests
  • git diff HEAD^ HEAD --check

Fixes #766


PR Type

Bug fix


Description

  • Update Homebrew Cask to v1.3.14 to fix download failure.

  • Update SHA-256 checksums for arm64 and Intel.

  • Add macOS Monterey as minimum system requirement.


Diagram Walkthrough

flowchart LR
    Old["v1.3.12 Cask"] -->|Update version & SHA| New["v1.3.14 Cask"]
    Old -->|Add macOS requirement| Monterey["depends_on macos: :monterey"]
Loading

File Walkthrough

Relevant files
Bug fix
openless.rb
Update version to v1.3.14 and add macOS Monterey dependency

Casks/openless.rb

  • Bump version from 1.3.12 to 1.3.14.
  • Update SHA-256 values for arm64 and Intel.
  • Simplify description text.
  • Add depends_on macos: :monterey.
+5/-4     

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit f0d86ee)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

766 - Fully compliant

Compliant requirements:

  • Updated version to v1.3.14 which exists on the releases page
  • Updated SHA-256 checksums for both arm64 and Intel DMGs
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@appergb appergb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required — Casks/openless.rb:18: 请在 artifact stanza 前增加 depends_on macos: :monterey。v1.3.14 的 arm64 和 x86_64 DMG 均声明 LSMinimumSystemVersion=12.0,但当前 Cask 没有声明 macOS-only/最低版本;在 Homebrew 6.0.10 上,brew readall --aliases review802/openless 会分别把 Linux/Intel 与 Linux/ARM64 判为 invalid cask(Linux 上 sha256 为 nil),brew style --cask 也报 Homebrew/OSDependsOn。补充该 stanza 后既能阻止 Linux/旧 macOS 走到无效下载路径,也能准确表达发布制品约束。

其余核验通过:PR 仅改 Casks/openless.rb 3+/3-,目标为 beta 且与最新 origin/beta 为 0 behind / 1 ahead;Fixes #766 正确;两个 URL 均返回 200;arm64 SHA-256 为 4bfa85f48714626ec010b92d22a5ab98c834f60b5c7e5f6281e12a11ad90ad9f,x86_64 为 929ad6c047fc8942724b7e1edb5dc0d88affbd2ec4184b2dd3d482c0e06d999f;两份 DMG 的 hdiutil verify 均有效且都包含 OpenLess.app 1.3.14;brew fetch 两架构分别成功,brew livecheck1.3.14 ==> 1.3.14。当前 CI Android/macOS/Linux/PR-Agent 已通过,Windows 仍在运行。

结论:REQUEST CHANGES。当前登录账号是 PR 作者,GitHub 禁止对自己的 PR 提交正式 request-changes review,因此这里以 comment review 留下相同的阻断意见。

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit f0d86ee

@appergb appergb left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

复审结论:逻辑 APPROVE(无阻断 findings)。

已针对 head f0d86ee65e5a10a1da6fe478723d2caa1cd34356 完整复核:

  • 先前 blocker 已解决:depends_on macos: :monterey 与 arm64/x86_64 两份 DMG 的 LSMinimumSystemVersion=12.0 完全一致;strict + online audit 明确输出 detected/declared minimum 均为 Monterey。
  • descMenu-bar voice input layer for macOS 精简为 Menu-bar voice input layer 合理,消除了 Homebrew Cask/Desc 的平台冗余规则告警。
  • ruby -cbrew audit --cask --strictbrew audit --strict --onlinebrew style --caskbrew readall --aliases --os all --arch allbrew livecheck 均通过;brew fetch arm、intel 和 all-platforms 均验证成功(Linux 组合按 macOS-only 声明正常跳过)。
  • 两个 DMG 均通过 hdiutil verify,内含 1.3.14 的对应 arm64/x86_64 OpenLess.app;SHA-256 分别为 4bfa85f48714626ec010b92d22a5ab98c834f60b5c7e5f6281e12a11ad90ad9f929ad6c047fc8942724b7e1edb5dc0d88affbd2ec4184b2dd3d482c0e06d999f
  • PR 仅修改非 UI 的 Casks/openless.rb(5+/4-),目标 beta,相对最新 Beta 为 0 behind / 2 ahead,git diff --check 通过,Fixes #766 正确。
  • Android、Linux、Windows、macOS、PR-Agent 五项 GitHub checks 全部成功;GitHub 报告 MERGEABLE。

当前 GitHub 登录账号与 PR 作者相同,平台不允许正式 APPROVE,因此以 COMMENTED review 记录等价的独立逻辑批准和验证证据。

@appergb
appergb merged commit ef6f1fa into beta Jul 14, 2026
5 checks passed
@appergb
appergb deleted the fix/issue-766-homebrew-cask branch July 14, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macos] 使用 homebrew 安装失败 cask 版本有误

1 participant