Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC device flow: visual indication that notebook is waiting #237

Closed
soxofaan opened this issue Sep 13, 2021 · 3 comments
Closed

OIDC device flow: visual indication that notebook is waiting #237

soxofaan opened this issue Sep 13, 2021 · 3 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Sep 13, 2021

When doing the OIDC device flow in a notebook (or even as a regular script), the con.authenticate_oidc() call (or related) will print something like

To authenticate: visit https://aai.egi.eu/oidc/device and enter the user code 'F0oB6r'.

and then do noting (except waiting).

It would be cool if there was a more visual indication that the client code is waiting for the user to do something: e.g. some kind of spinner, progress bar (based on waiting timeout), ...

@soxofaan
Copy link
Member Author

problem with current implementation: output text widget in jupyter notebook is now refreshed every 1, which makes it hard/impossible to select the url or code for copy pasting, which is a usability regression

@soxofaan
Copy link
Member Author

Also to do: progress bar should be cleaned up (or a new line should be added), now it looks like this:

To authenticate: visit https://aai.egi.eu/oidc/device and enter the user code '.....'.
Authorized successfully.   ] Waiting for authentication.             
Authenticated using device code flow.

soxofaan added a commit that referenced this issue Apr 19, 2023
soxofaan added a commit that referenced this issue Apr 19, 2023
soxofaan added a commit that referenced this issue Apr 25, 2023
soxofaan added a commit that referenced this issue Apr 25, 2023
soxofaan added a commit that referenced this issue Apr 26, 2023
soxofaan added a commit that referenced this issue Apr 26, 2023
soxofaan added a commit that referenced this issue May 2, 2023
soxofaan added a commit that referenced this issue May 2, 2023
soxofaan added a commit that referenced this issue May 2, 2023
soxofaan added a commit that referenced this issue May 2, 2023
soxofaan added a commit that referenced this issue May 3, 2023
soxofaan added a commit that referenced this issue May 9, 2023
soxofaan added a commit that referenced this issue May 9, 2023
@soxofaan
Copy link
Member Author

soxofaan commented May 9, 2023

implemented in #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant