Updated googletest version to v1.6.0 #2031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumeh01
force-pushed
the
gtest_version_update
branch
from
4db9fe5 to
ca732e1
Compare
Test Results 7 files 53 suites 5m 23s ⏱️ Results for commit 34aea92. ♻️ This comment has been updated with latest results. |
soumeh01
force-pushed
the
gtest_version_update
branch
from
ca732e1 to
48f373d
Compare
soumeh01
force-pushed
the
gtest_version_update
branch
2 times, most recently
from
5229bb3 to
a850886
Compare
soumeh01
force-pushed
the
gtest_version_update
branch
from
a850886 to
34aea92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 66.09% 66.09%
=======================================
Files 173 173
Lines 35982 35982
Branches 20917 20917
=======================================
Hits 23781 23781
Misses 7863 7863
Partials 4338 4338
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
brondani
pushed a commit
to brondani/devtools
that referenced
this pull request
Apr 3, 2025
Failure occurred due to the deprecation of support for CMake versions earlier than 3.10. Since the Ubuntu GitHub runner uses CMake 3.31.6, which no longer supports versions prior to 3.10 in many cases, our pinned version of GoogleTest needed an update. Additionally, other dependencies, such as JSON and JSON Schema Validators, were updated to the minimum compatible versions, with 3.5 being the lowest supported. https://cmake.org/cmake/help/latest/release/3.31.html#deprecated-and-removed-features The change includes: - Pin googletest to latest v1.16.0 - yaml-cpp patch update `cmake_minimum_required(VERSION 3.10)` - json patch update `cmake_minimum_required(VERSION 3.10)` - json-schema-validator patch update `cmake_minimum_required(VERSION 3.10)` - Updated ubuntu-20.04 to ubuntu-22.04. **GitHub Actions is deprecating the ubuntu-20.04 runner**.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure occurred due to the deprecation of support for CMake versions earlier than 3.10. Since the Ubuntu GitHub runner uses CMake 3.31.6, which no longer supports versions prior to 3.10 in many cases, our pinned version of GoogleTest needed an update. Additionally, other dependencies, such as JSON and JSON Schema Validators, were updated to the minimum compatible versions, with 3.5 being the lowest supported.
https://cmake.org/cmake/help/latest/release/3.31.html#deprecated-and-removed-features
The change includes:
cmake_minimum_required(VERSION 3.10)cmake_minimum_required(VERSION 3.10)cmake_minimum_required(VERSION 3.10)