-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cbuild-pack.yml] Document cbuild-pack.yml #76
[cbuild-pack.yml] Document cbuild-pack.yml #76
Conversation
Contributed by STMicroelectronics Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
updated Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Updated the PR with a bit more clarification on when the cbuild-pack.yml is used and updated: |
@slhultgren thanks a lot for adding detail to the documentation regarding the reading and writing of the cbuild-pack.yml file and which We are frequently discussing the aspect of "backward compatibility". With the introduction of the cbuild-pack.yml the previous behavior is changed such that after installing an updated pack version used by a csolution which does not fix the pack version, the newly installed pack version will not be used. My request is to add a For strict backward compatibility the cbuild-pack.yml would be disabled by default and require
We could consider an explicit entry in the
Storing this information in the solution, would allow the |
@slhultgren thanks for documenting the feature. I agree with @jkrech to add a option for enabling this feature. |
I believe just one option is enough. By default the file Option: The option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Extensions like command line options to be added in separate PR.
Document cbuild-pack.yml introduced in PR Open-CMSIS-Pack/devtools#1143
Fixes Open-CMSIS-Pack/devtools#1122
Contributed by STMicroelectronics
Easiest way to read it is by looking at the rendered form https://github.com/slhultgren/cmsis-toolbox/blob/pr/shu-cbuild-pack-documentation/docs/YML-CBuild-Format.md#pack-locking