Fix/freeze dict keys #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusfrost
force-pushed
the
fix/freeze_dict_keys
branch
from
91a4128 to
d873e56
Compare
|
Thanks for the suggestion. I am actually not sure if we want to freeze everything, even if not needed. But it probably doesn't hurt either 🤔 @cffls maybe you know about use cases of unfrozen serialized output? |
|
As long as we don't change the original object, I think it is okay to freeze everything before serializing them. I can't think of cases where users would want to modify the output of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.