Skip to content

Easter egg hunt setting #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Nov 26, 2022

This adds a setting that replaces all Triforce pieces in the item pool with Easter eggs. Easter eggs come in four colors and otherwise behave like Triforce pieces, so this is purely a visual change.

This setting has been used twice for Freaky Friday races around Easter, so having it on main Dev would be convenient if they wanted to repeat this in the future. The changes made to get things working (including in multiworld) could also be useful for anyone implementing their own variant of Triforce Hunt, such as Triforce Blitz. Since it's somewhat of a niche setting, I decided not to include it in the GUI, though this can of course be changed if desired.

Credit to @KevinPal for the original implementation this PR is based on. The main change compared to that branch is that instead of editing the egg item model from the base game to be pink, this PR adds edited copies as new files. This means that the Weird Egg and the Pocket Egg retain their vanilla appearance.

The feature is ready to play in its current state, but there are some nice-to-have things currently missing:

  • Easter eggs are missing cryptic hint text, so they're currently hinted as “an Easter Egg” even without the Clearer Hints setting. Suggestions welcome.
  • The HUD still displays a rotating Triforce piece. If anyone knows how to edit it, it would be cool to have it display as an Easter egg with some sort of pattern painted on it so the rotating animation is visible.

@r0bd0g
Copy link

r0bd0g commented Nov 26, 2022

I suggest removing references to "Easter" and just calling it an Egg hunt or something along those lines.

@fenhl
Copy link
Collaborator Author

fenhl commented Nov 26, 2022

Why?

@r0bd0g
Copy link

r0bd0g commented Nov 26, 2022

I don't think the religious reference is appropriate.
Honestly the whole setting leaves a bad taste.
(Next up, replace all hints with Bible verses.)

@fenhl fenhl force-pushed the easter-egg-hunt branch 2 times, most recently from 2b26e7e to 3ec9fa1 Compare November 26, 2022 16:39
@fenhl
Copy link
Collaborator Author

fenhl commented Nov 27, 2022

I was under the mistaken assumption that Easter egg hunts weren't an exclusively Christian thing. Still, I think the religious reference is fine given that it's in a hidden and completely optional setting, and not comparable to the most recent edit of your comment, which would be forcing something on everyone. Including the word Easter in the name helps quickly explain what the setting does, and I don't think leaving it out would make much of a difference since the reference would be easily identifiable regardless. That said, if there are others who share this concern, I'd be willing to reconsider, so please speak up. In the meantime, I'll be rethinking how to handle this setting on my personal branch where it does appear on the GUI.

@r0bd0g
Copy link

r0bd0g commented Nov 27, 2022

(I meant it like, the egg hunt setting would be the one with the bible verses everywhere. Like, just fully embrace the Message.)
Did you remember the altar wincon text?

@Cuphat
Copy link
Collaborator

Cuphat commented Nov 27, 2022

I do find it funny that by making it a hidden setting that can't be enabled on the GUI, it turns the setting into... an easter egg.

@cjohnson57
Copy link
Collaborator

Yeah I mean, sure the Easter holiday has religious connotations but so does Christmas and it feels a bit much to restrict usage of the word. Especially when Easter Egg has become such a ubiquitous term in game culture.

That being said, I'm not sure if I feel this should really be something for the main branch. Maple and I wanted to make a Golden Banana TH at some point and I never considered bringing it to main, lol

@fenhl
Copy link
Collaborator Author

fenhl commented Nov 29, 2022

Marking as draft since a gen failure was discovered that happens when the randomizer attempts to cloak an ice trap as an Easter egg (since Easter eggs have get item IDs greater than 255).

@fenhl fenhl marked this pull request as draft November 29, 2022 22:55
@fenhl fenhl marked this pull request as ready for review December 14, 2022 12:51
@Cuphat Cuphat added Component: Setting specific to setting(s) Component: ASM/C Changes some internals of the ASM/C libraries labels Jan 2, 2023
@cjohnson57 cjohnson57 added the Status: Under Consideration Developers are considering whether to accept or decline the feature described label Jan 8, 2023
@cjohnson57
Copy link
Collaborator

Sorry, don't think we'll be merging this

@cjohnson57 cjohnson57 closed this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Component: Setting specific to setting(s) Status: Under Consideration Developers are considering whether to accept or decline the feature described
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants