test: [TestCase] define database migrations #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericHao22
approved these changes
Jul 6, 2023
Comment on lines
+28
to
+35
| * Define database migrations. | ||
| */ | ||
| protected function defineDatabaseMigrations(): void | ||
| { | ||
| $this->loadLaravelMigrations(); | ||
| $this->loadMigrationsFrom(__DIR__ . '/../database/migrations'); | ||
| $this->loadMigrationsFrom(__DIR__ . '/Migrations'); | ||
| } |
There was a problem hiding this comment.
💬 comment
當初沒特別加的原因是，不一定每個套件都會有table schema，要是沒有的話它嘗試去load migration有可能會報錯？
不過如果真的要加感覺可以保留$this->loadLaravelMigrations();，然後其他的先註解掉也行
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.