Changes for Issue 169 #173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Hi @remingtontr, this PR is too big. A PR should only deal with a single concern, like editing an article, or fixing markdown and links in a specific chapter. Otherwise it's too hard to review everything. Please create a new PR for the changes to the opkg content. We should discuss the markdown and link fixes before moving forward. |
|
Okay.
I wasn't aware we could use bare links for Docusaurus - noted for future.
Tom Remington
…________________________________
From: Lazar ***@***.***>
Sent: November 4, 2024 1:50 PM
To: OnionIoT/documentation ***@***.***>
Cc: remingtontr ***@***.***>; Mention ***@***.***>
Subject: Re: [OnionIoT/documentation] Changes for Issue 169 (PR #173)
Hi @remingtontr<https://github.com/remingtontr>, this PR is too big. A PR should only deal with a single concern, like editing an article, or fixing markdown and links in a specific chapter. Otherwise it's too hard to review everything.
Please create a new PR for the changes to the opkg content.
We should discuss the markdown and link fixes before moving forward.
Docusaurus automatically hyperlinks bare URLs, so we don't need to use markdown link syntax for those. I'll add that to the style guide.
—
Reply to this email directly, view it on GitHub<#173 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4B4PDM24O4DM7FEMND2V3TZ67MZDAVCNFSM6AAAAABRC4HGFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVG43TCOBYGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I have created a PR Issue-169b that contains only the opkg content.
Tom Remington
…________________________________
From: Lazar ***@***.***>
Sent: November 4, 2024 1:50 PM
To: OnionIoT/documentation ***@***.***>
Cc: remingtontr ***@***.***>; Mention ***@***.***>
Subject: Re: [OnionIoT/documentation] Changes for Issue 169 (PR #173)
Hi @remingtontr<https://github.com/remingtontr>, this PR is too big. A PR should only deal with a single concern, like editing an article, or fixing markdown and links in a specific chapter. Otherwise it's too hard to review everything.
Please create a new PR for the changes to the opkg content.
We should discuss the markdown and link fixes before moving forward.
Docusaurus automatically hyperlinks bare URLs, so we don't need to use markdown link syntax for those. I'll add that to the style guide.
—
Reply to this email directly, view it on GitHub<#173 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4B4PDM24O4DM7FEMND2V3TZ67MZDAVCNFSM6AAAAABRC4HGFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJVG43TCOBYGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new small section to describe advanced package management.
I also corrected some small markdown errors in several files and rechecked links that were modified.
Notes:
These two files are not in the menu for their respective chapters - should they be?
This file is not referenced in other files within the chapter.
hardware-interfaces/external-storage.md
This file is linked to from another article in the chapter.
introduction/determine-fw-version.md
The link for the Linux 3.xxx VCP driver ends up on an error page, but the 2.6 one works correctly.
hardware/serial-command-line.md