-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nn utils spectral norm new #9967
Draft
ehuaa
wants to merge
4
commits into
master
Choose a base branch
from
nn_utils_spectral_norm_new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuaa
requested review from
oneflow-ci-bot,
tangnana925,
Ikkyu321 and
yoonlee888
March 9, 2023 09:09
ehuaa
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
March 9, 2023 09:13
CI failed when running job: Build cpu. PR label automerge has been removed |
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
看了oneflow上之前spectral norm一些同学的相关照搬pytorch的提交有以下问题,可以精简
1.增加 spectral_norm 的基本功能, 查看pytorch 实现spectral_norm的源代码中的很多注释,
其实很多 SpectralNormStateDictHook以及SpectralNormLoadStateDictPreHook 因为涉及到和之前出现bug的老版本spectral_norm的线上代码向下兼容所以才需要添加,oneflow中也不需要。
2. Pytorch中很多代码bug相关的修改是针对其特殊架构下的DataParallel模式下的改动,Oneflow中并不需要做相应修改。
pytorch/pytorch@2cd912b
pytorch/pytorch@ac994f2
代码格式化 - √
已经本地编译通过 - √
已本地针对改动测试 - √
添加 enhancement 标签 - √
Draft 转正式 PR 前已请人Review - √