Positional encoding #9772
Draft
Positional encoding #9772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
编写fused_sinusoidal_positional_encode实现如下逻辑 |
liujuncheng
reviewed
Jan 28, 2023
| ); | ||
| let attrs = (ins | ||
| SI32Attr:$embedding_dim, | ||
| DefaultValuedAttr<SI32Attr, "0">:$pattern, |
There was a problem hiding this comment.
pattern是不是换成layout更好
这里可以考虑传字符串
| int max_period; | ||
| }; | ||
|
|
||
| enum class EncodingPattern { |
There was a problem hiding this comment.
Suggested change
| enum class EncodingPattern { | |
| enum class EncodingLayout{ |
| }; | ||
|
|
||
| enum class EncodingPattern { | ||
| SIN_COS, |
There was a problem hiding this comment.
Suggested change
| SIN_COS, | |
| kPlanarSinCos, |
| } | ||
| } | ||
|
|
||
| __global__ void PaddingKernel(float* out_ptr, int N, int embedding_dim) { |
Comment on lines
146
to
147
| DispatchSrcType(positions->data_type(), EncodeType::SIN, sin_param); | ||
| DispatchSrcType(positions->data_type(), EncodeType::COS, cos_param); |
There was a problem hiding this comment.
这里调用两次，就会有两次的启动开销，同时是不是还会有非连续访存的问题，尽量使用一次kernel launch，同时保证连续访存
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.