Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the usage of argument end_factor in LinearLR #9421

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Fix the usage of argument end_factor in LinearLR #9421

merged 5 commits into from
Nov 15, 2022

Conversation

leaves-zwx
Copy link
Contributor

@leaves-zwx leaves-zwx commented Nov 14, 2022 •
edited
Loading

From #8349

Formatting bypass the limits of authority.

@leaves-zwx leaves-zwx self-assigned this Nov 14, 2022
@leaves-zwx leaves-zwx mentioned this pull request Nov 14, 2022
Closed
@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 140.8ms (= 14075.2ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.3ms (= 16030.7ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 160.3ms / 140.8ms)

OneFlow resnet50 time: 84.8ms (= 8483.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 99.8ms (= 9977.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.18 (= 99.8ms / 84.8ms)

OneFlow resnet50 time: 57.5ms (= 11499.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.4ms (= 15689.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 78.4ms / 57.5ms)

OneFlow resnet50 time: 44.3ms (= 8863.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.4ms (= 14082.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.59 (= 70.4ms / 44.3ms)

OneFlow resnet50 time: 40.7ms (= 8132.8ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.1ms (= 12415.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.53 (= 62.1ms / 40.7ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9421/

@mergify mergify bot merged commit be258a2 into master Nov 15, 2022
@mergify mergify bot deleted the fix_linear_lr_end_factor branch November 15, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujuncheng liujuncheng liujuncheng approved these changes

@jackalcooper jackalcooper jackalcooper approved these changes

@BBuf BBuf Awaiting requested review from BBuf

@daquexian daquexian Awaiting requested review from daquexian

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees

@leaves-zwx leaves-zwx

Labels
api automerge bug python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leaves-zwx @liujuncheng @jackalcooper