fix flow.load in multi nodes and add test #8314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daquexian <daquexian566@gmail.com>
strint
reviewed
May 26, 2022
| @@ -295,10 +295,10 @@ def load(path: str, global_src_rank: Optional[int] = None,) -> Any: | |||
| The loaded object | |||
| """ | |||
| path: Path = Path(path) | |||
| assert path.is_dir(), "Directory {} doesn't exist!".format(path) | |||
| pickle_path = path / PICKLE_FILENAME | |||
There was a problem hiding this comment.
之前这里另外一个膜而已 dir 的机器会报错对吧。报错后不会卡住，会导致所有rank最终都挂掉？
strint
approved these changes
May 26, 2022
Flowingsun007
approved these changes
May 26, 2022
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8314/ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复多机 flow.load 出错的问题