Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine onednn primitive & use runitme env var to enable onednn #8274

Merged
merged 14 commits into from
May 25, 2022

Conversation

mosout
Copy link
Contributor

@mosout mosout commented May 22, 2022

No description provided.

@mosout mosout requested a review from liujuncheng as a code owner May 22, 2022 14:01
@mosout mosout requested a review from daquexian May 22, 2022 14:01
@@ -27,6 +27,64 @@ Maybe<void> CpuStream::Sync() { return Maybe<void>::Ok(); }

void CpuStream::RecordEvent(Event* /*event*/) {}

void CpuStream::ParallelFor(int64_t begin, int64_t end, const ParallelForFuncType& func) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 func 还是建议用模板参数类型好一些,std::function 有额外开销

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

虽然但是我觉得我们是不是可以搞一个轻量的 std::function 直接用模板参数类型感觉不是很清真


namespace oneflow {

DEFINE_ENV_BOOL(ONEFLOW_ENABLE_ONEDNN_OPTS, true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 OPTS 是什么的缩写

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosout mosout requested a review from liujuncheng May 25, 2022 05:31
@mosout mosout requested review from oneflow-ci-bot and removed request for oneflow-ci-bot May 25, 2022 06:35
@mergify mergify bot merged commit 351022c into Oneflow-Inc:master May 25, 2022
@mosout mosout deleted the refine_onednn branch June 1, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants