Refine onednn primitive & use runitme env var to enable onednn #8274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
reviewed
May 24, 2022
oneflow/core/ep/cpu/cpu_stream.cpp
Outdated
| @@ -27,6 +27,64 @@ Maybe<void> CpuStream::Sync() { return Maybe<void>::Ok(); } | |||
|
|
|||
| void CpuStream::RecordEvent(Event* /*event*/) {} | |||
|
|
|||
| void CpuStream::ParallelFor(int64_t begin, int64_t end, const ParallelForFuncType& func) { | |||
There was a problem hiding this comment.
这里 func 还是建议用模板参数类型好一些，std::function 有额外开销
There was a problem hiding this comment.
虽然但是我觉得我们是不是可以搞一个轻量的 std::function 直接用模板参数类型感觉不是很清真
daquexian
approved these changes
May 25, 2022
liujuncheng
reviewed
May 25, 2022
|
|
||
| namespace oneflow { | ||
|
|
||
| DEFINE_ENV_BOOL(ONEFLOW_ENABLE_ONEDNN_OPTS, true); |
There was a problem hiding this comment.
liujuncheng
approved these changes
May 25, 2022
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.