Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bbm check info #8186

Merged
merged 6 commits into from
May 13, 2022
Merged

fix bbm check info #8186

merged 6 commits into from
May 13, 2022

Conversation

simonJJJ
Copy link
Contributor

之前bmm的check是在瞎写。

@simonJJJ simonJJJ requested a review from BBuf May 11, 2022 07:25
@simonJJJ simonJJJ requested a review from hjchen2 as a code owner May 11, 2022 07:25
BBuf
BBuf approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@BBuf BBuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以补一个exception的测试

@simonJJJ simonJJJ requested a review from oneflow-ci-bot May 12, 2022 07:38
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8186/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: NVIDIA GeForce GTX 1080 

❌ OneFlow resnet50 time: 129.6ms (= 12956.3ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 143.1ms (= 14307.6ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.10 (= 143.1ms / 129.6ms)

OneFlow resnet50 time: 81.1ms (= 8112.3ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 87.6ms (= 8761.3ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.08 (= 87.6ms / 81.1ms)

OneFlow resnet50 time: 53.2ms (= 10637.4ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 59.6ms (= 11928.1ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.12 (= 59.6ms / 53.2ms)

OneFlow resnet50 time: 43.1ms (= 8629.2ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 44.7ms (= 8939.6ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.04 (= 44.7ms / 43.1ms)

OneFlow resnet50 time: 38.3ms (= 7654.2ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 39.4ms (= 7871.3ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.03 (= 39.4ms / 38.3ms)

OneFlow swin dataloader time: 0.253s (= 50.638s / 200, num_workers=1)
PyTorch swin dataloader time: 0.150s (= 30.056s / 200, num_workers=1)
Relative speed: 0.594 (= 0.150s / 0.253s)

OneFlow swin dataloader time: 0.066s (= 13.269s / 200, num_workers=4)
PyTorch swin dataloader time: 0.041s (= 8.183s / 200, num_workers=4)
Relative speed: 0.617 (= 0.041s / 0.066s)

OneFlow swin dataloader time: 0.038s (= 7.561s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.444s / 200, num_workers=8)
Relative speed: 0.588 (= 0.022s / 0.038s)

❌ OneFlow resnet50 time: 145.6ms (= 14562.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 169.2ms (= 16920.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.16 (= 169.2ms / 145.6ms)

OneFlow resnet50 time: 97.4ms (= 9743.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 112.9ms (= 11286.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.16 (= 112.9ms / 97.4ms)

OneFlow resnet50 time: 76.5ms (= 15290.5ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.2ms (= 17633.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
❌ Relative speed: 1.15 (= 88.2ms / 76.5ms)

OneFlow resnet50 time: 59.0ms (= 11806.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.1ms (= 15611.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.32 (= 78.1ms / 59.0ms)

OneFlow resnet50 time: 57.5ms (= 11496.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.4ms (= 13878.1ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 69.4ms / 57.5ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8186/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: NVIDIA GeForce GTX 1080 

❌ OneFlow resnet50 time: 129.2ms (= 12917.4ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 142.2ms (= 14223.7ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.10 (= 142.2ms / 129.2ms)

OneFlow resnet50 time: 78.0ms (= 7803.5ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.6ms (= 8462.4ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.08 (= 84.6ms / 78.0ms)

OneFlow resnet50 time: 52.7ms (= 10542.5ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.9ms (= 11786.6ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.12 (= 58.9ms / 52.7ms)

OneFlow resnet50 time: 42.8ms (= 8568.9ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 45.6ms (= 9111.2ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.06 (= 45.6ms / 42.8ms)

OneFlow resnet50 time: 35.0ms (= 7000.3ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 37.2ms (= 7435.6ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.06 (= 37.2ms / 35.0ms)

OneFlow swin dataloader time: 0.260s (= 51.924s / 200, num_workers=1)
PyTorch swin dataloader time: 0.149s (= 29.727s / 200, num_workers=1)
Relative speed: 0.573 (= 0.149s / 0.260s)

OneFlow swin dataloader time: 0.068s (= 13.635s / 200, num_workers=4)
PyTorch swin dataloader time: 0.041s (= 8.249s / 200, num_workers=4)
Relative speed: 0.605 (= 0.041s / 0.068s)

OneFlow swin dataloader time: 0.061s (= 12.117s / 200, num_workers=8)
PyTorch swin dataloader time: 0.022s (= 4.371s / 200, num_workers=8)
Relative speed: 0.361 (= 0.022s / 0.061s)

❌ OneFlow resnet50 time: 145.0ms (= 14500.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 168.0ms (= 16804.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.16 (= 168.0ms / 145.0ms)

OneFlow resnet50 time: 96.3ms (= 9632.3ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 122.0ms (= 12200.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.27 (= 122.0ms / 96.3ms)

OneFlow resnet50 time: 73.1ms (= 14619.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.9ms (= 17782.2ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.22 (= 88.9ms / 73.1ms)

OneFlow resnet50 time: 58.6ms (= 11710.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 81.4ms (= 16284.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.39 (= 81.4ms / 58.6ms)

OneFlow resnet50 time: 55.8ms (= 11164.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 75.8ms (= 15150.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 75.8ms / 55.8ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8186/

@mergify mergify bot merged commit b41549c into master May 13, 2022
@mergify mergify bot deleted the fix_bbm_checkinfo branch May 13, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flowingsun007 Flowingsun007 Flowingsun007 approved these changes

@BBuf BBuf BBuf approved these changes

@hjchen2 hjchen2 Awaiting requested review from hjchen2 hjchen2 is a code owner

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
api automerge bug eager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonJJJ @Flowingsun007 @BBuf