Use cpu for slice boxing if device is not cpu and cuda #8180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use_cpu_for_slice_boxing_if_device_is_not_cpu_and_cuda
…use_cpu_for_slice_boxing_if_device_is_not_cpu_and_cuda
wyg1997
approved these changes
May 23, 2022
… of https://github.com/Oneflow-Inc/oneflow into use_cpu_for_slice_boxing_if_device_is_not_cpu_and_cuda
hjchen2
reviewed
May 23, 2022
Comment on lines
+53
to
+54
| template<Maybe<one::Tensor> (*func)(const std::shared_ptr<one::Tensor>&, Symbol<PlacedNdSbp>, | ||
| Symbol<PlacedNdSbp>)> |
There was a problem hiding this comment.
这里template<typename func>就行
There was a problem hiding this comment.
这里
template<typename func>就行
template<typename func>的话需要Func作为变量作为输入参数，上面写法可以将一个函数指针作为特化值，二者还是有一定的区别
There was a problem hiding this comment.
我是说template会更简单一些，不一定需要将Func作为输入参数，你可以写成template<typename Func, Func* func>，func的类型自动推导，写起来会更简单一些
hjchen2
approved these changes
May 23, 2022
|
View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/8180/ |
clackhan
deleted the
use_cpu_for_slice_boxing_if_device_is_not_cpu_and_cuda
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改 eager slice boxing计算图，当tensor的设备类型既不是cpu又不是cuda时，将tensor 拷贝到cpu上，在cpu上做boxing，然后在结果拷回到对应的设备上。此pr为添加一种新的设备类型时，提供最基本的eager boxing 支持